librustc: Remove the ability for extern crate to specify crate IDs.
#14887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue rust-lang#14468. After a snapshot, it will be possible to remove the `extern crate foo = STRING` syntax in favor of the new `extern crate foo = IDENT`. This will break crates that have names that are not valid Rust identifiers (in particular, those that contain hyphens). Change such crates to have names that correspond to valid Rust identifiers. (Most commonly, this will involve changing hyphens to underscores.) [breaking-change]
|
The corresponding RFC for this is rust-lang/rfcs#109, and this should probably wait for that to be merged. |
|
Also, the RFC should be mentioned in the commit message. Something to do during the rebase. |
|
The RFC has been accepted now, and the relevant section for this issue dictates that the syntax is still |
|
Superseded by #15319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #14468.
After a snapshot, it will be possible to remove the
extern crate foo = STRINGsyntax in favor of the newextern crate foo = IDENT.This will break crates that have names that are not valid Rust
identifiers (in particular, those that contain hyphens). Change such
crates to have names that correspond to valid Rust identifiers. (Most
commonly, this will involve changing hyphens to underscores.)
[breaking-change]
r? @brson
This may require an RFC to be merged first, but I wanted to go ahead and get the work done.