Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1352: change param order on vec::init_fn (and vec::init_fn_mut), putting block in final position. #1559

Closed
wants to merge 3 commits into from
Closed

fix #1352: change param order on vec::init_fn (and vec::init_fn_mut), putting block in final position. #1559

wants to merge 3 commits into from

Conversation

gmfawcett
Copy link
Contributor

No description provided.

@nikomatsakis
Copy link
Contributor

can we adjust init_elt() to match?

@gmfawcett
Copy link
Contributor Author

Sure. I suspect str_init_elt ought to change too...

@gmfawcett
issue #1352: change param order on vec::init_elt, putting block in fi…
8f33d3d 
…nal position.

To match the init_fn() and init_fn_mut() changes.
@gmfawcett
Copy link
Contributor Author

Argh, bad commit message on 8f33d3d, I copied "putting block in final position" line, which is bogus for init_elt.

@gmfawcett
Copy link
Contributor Author

If you pull this, you should probably advertise the init_elt() change, since usages of init_elt<uint>() will break silently. [edit: the markdown renderer dropped out the <uint>]

@brson
Copy link
Contributor

brson commented Jan 21, 2012

Merged, and message sent to rust-dev about the silent breakage. Thanks!

@brson brson closed this Jan 21, 2012
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 11, 2021
@bors
Auto merge of rust-lang#6853 - Jarcho:len_without_is_empty_fp, r=Mani…
e451d6e 
…shearth

`len_without_is_empty` will now consider multiple impl blocks

fixes rust-lang#1562

This also reverts rust-lang#1559 as the `#[allow]` now works on the `len` method. A note has also been added to point out where the `empty` method is, if it exists.

changelog: `len_without_is_empty` will now consider multiple impl blocks
changelog: `len_without_is_empty` will now consider `#[allow]` on both the `len` method, and the type definition
celinval pushed a commit to celinval/rust-dev that referenced this pull request Jun 4, 2024
@YoshikiTakashima
Implement -p flag for running kani on specific package (rust-lang#1559
efd082c 
)

* Implement -p / --package flag.

* Fixed comments.

* Modified tests to check running 2/3 tests.

1/2 does not show up in a way that we can check!

* Fixed -p to match build: multiple packages allowed.

* Forced one of the active packages to fail, enforce expected

* Changed name of test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmfawcett @nikomatsakis @brson