Remove runtime failure from pattern matching #15700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| dynamic_failure_handler.handle_fail() | ||
| } | ||
| Infallible => | ||
| fail!("attempted to fail in infallible failure handler!"), |
There was a problem hiding this comment.
I assume "attempted to fail" doesn't mean fail!(), but rather "attempted to not match". (aka "infallable" is being used as a synonym for "irrefutable" here?)
There was a problem hiding this comment.
Yes, where irrefutable refers to a specific branch of the decision tree. Unless guards or slice patterns are involved, only one branch in the tree has to be explored. And not matching is impossible because of the exhaustiveness guarantee. It is possible when guards or var-length slice patterns are involved, however, in which case it will jump to the next appropriate branch.
It's an artifact of the old refutable version of `match` and is no longer necessary.
bors
added a commit
that referenced
this pull request
Jul 21, 2014
It's an artifact of the old refutable version of `match` and is no longer necessary.
ghost
deleted the
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
…eykril feat: add assist for applying De Morgan's law to `Iterator::all` and `Iterator::any` This PR adds an assist for transforming expressions of the form `!iter.any(|x| predicate(x))` into `iter.all(|x| !predicate(x))` and vice versa. [IteratorDeMorgans.webm](https://github.com/rust-lang/rust-analyzer/assets/52933714/aad1a299-6620-432b-9106-aafd2a7fa9f5) Closes rust-lang#15694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an artifact of the old refutable version of
matchand is no longer necessary.