Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for tutorial. #15745

Merged
merged 1 commit into from
Jul 20, 2014
Merged

Small fixes for tutorial. #15745

merged 1 commit into from
Jul 20, 2014

Conversation

treeman
Copy link
Contributor

@treeman treeman commented Jul 17, 2014

Simplify example in 5.2 to remove hidden #[deriving(Show)]. Traits haven't been introduced yet and now it's easier to just type in the code and expect it to work. Add in some examples for constructing the enum types. Explicitly expose #![feature(struct_variant)] in the code to make it more transparent, this bit me when I worked through the tutorial.

Add references in chapter 8 to later chapters describing Rc, Gc and Send. This is a simple fix for #15293.

Simplify vector indexing example in chapter 13 and removed hidden, unnecessary, code. Gave an example usage of the derived Rand trait in chapter 17.

Removed references to removed 'extra' crate.

5.2 Simplify example to remove hidden #[deriving(Show)].
    Add example for constructing the enums.

8   Reference later sections describing rc, gc and send.
    Fix for #15293.

13  Simplify BananaMania example to remove hidden code.

17  Gave an example using the derived Rand trait.

Removed references to removed 'extra' crate.
@steveklabnik
Copy link
Member

Seems fine. The tutorial should only be around another couple of weeks anyway, but no reason to not improve it a bit in the meantime.

r+=me if a committer agrees

bors added a commit that referenced this pull request Jul 20, 2014
Simplify example in 5.2 to remove hidden `#[deriving(Show)]`. Traits haven't been introduced yet and now it's easier to just type in the code and expect it to work. Add in some examples for constructing the enum types. Explicitly expose `#![feature(struct_variant)]` in the code to make it more transparent, this bit me when I worked through the tutorial.

Add references in chapter 8 to later chapters describing `Rc`, `Gc` and `Send`. This is a simple fix for #15293.

Simplify vector indexing example in chapter 13 and removed hidden, unnecessary, code. Gave an example usage of the derived `Rand` trait in chapter 17.

Removed references to removed 'extra' crate.
@bors bors closed this Jul 20, 2014
@bors bors merged commit 89e28d3 into rust-lang:master Jul 20, 2014
@treeman treeman deleted the tutorial-fixup branch July 20, 2014 11:36
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants