Fix an ICE with trans of calls to foreign fns. Refactoring #17036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pczarn
force-pushed
the
issue-15913-ICE-with-call-trans
branch
2 times, most recently
from
ea924d3 to
67fa7ff
Compare
pczarn
changed the title
|
Can this have a test? |
|
@huonw, I'm not sure how to test for this ICE. It's almost a heisenbug. It happens when some foreign NodeId has the same number as a local one of a certain kind. |
It was failing occasionally.
pczarn
force-pushed
the
issue-15913-ICE-with-call-trans
branch
from
67fa7ff to
808e039
Compare
bors
added a commit
that referenced
this pull request
Sep 8, 2014
…=alexcrichton A match in callee.rs was recognizing some foreign fns as named tuple constructors. A reproducible test case for this is nearly impossible since it depends on the way NodeIds happen to be assigned in different crates. Fixes #15913
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
Revert "fix: set the right postfix snippets competion source range" This reverts commit c5686c8. Fix rust-lang#17036. See rust-lang/rust-analyzer#17036 (comment)
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
Revert "fix: set the right postfix snippets competion source range" This reverts commit c5686c8. Fix rust-lang#17036. See rust-lang/rust-analyzer#17036 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A match in callee.rs was recognizing some foreign fns as named tuple constructors. A reproducible test case for this is nearly impossible since it depends on the way NodeIds happen to be assigned in different crates.
Fixes #15913