Implement Slice for String and str #17585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
force-pushed
the
string-slice
branch
from
e5834fe to
aa2814f
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 29, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 28, 2024
fix: Panic in debug profile for tuple deconstruct with arity mismatch Fixes rust-lang#17585, which doesn't affect daily use cases but quite annoying in development of r-a itself like writing tests. This PR applies similar approach as in rust-lang#17534, skipping match usefulness check for patterns containing errors
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 1, 2024
fix: Panic in debug profile for tuple deconstruct with arity mismatch Fixes rust-lang#17585, which doesn't affect daily use cases but quite annoying in development of r-a itself like writing tests. This PR applies similar approach as in rust-lang#17534, skipping match usefulness check for patterns containing errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17502