Fix lev_distance in libcollections/str.rs #17738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test for this? |
|
@huonw Added a test yesterday. |
bors
added a commit
that referenced
this pull request
Oct 4, 2014
There is an issue with lev_distance, where
```
fn main() {
println!("{}", "\x80".lev_distance("\x80"))
}
```
prints `2`.
This is due to using the byte length instead of the char length.
| if tlen == 0 { return slen; } | ||
|
|
||
| let mut dcol = Vec::from_fn(tlen + 1, |x| x); | ||
| let mut dcol = Vec::from_fn(t.len() + 1, |x| x); |
There was a problem hiding this comment.
dcol is too long, should be just .char_len() + 1. The difference is often small though.
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 1, 2024
fix: Apply `IndexMut` obligations for non-assigning mutable index usages Fixes rust-lang#17738 Currently, we are pushing `IndexMut` obligations only for assign usages; https://github.com/rust-lang/rust-analyzer/blob/f982f3fa2c23570c10108e83c1ecc392ea411866/crates/hir-ty/src/infer/expr.rs#L809-L817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with lev_distance, where
prints
2.This is due to using the byte length instead of the char length.