Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

work around yet another MinGW-w64 ASLR bug #17809

Closed
wants to merge 1 commit into from
+4 −4
Closed

work around yet another MinGW-w64 ASLR bug #17809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/librustc/back/link.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,10 +1025,10 @@ fn link_args(cmd: &mut Command,
cmd.arg("-Wl,--nxcompat");

// Mark all dynamic libraries and executables as compatible with ASLR
// FIXME #17098: ASLR breaks gdb
if sess.opts.debuginfo == NoDebugInfo {
cmd.arg("-Wl,--dynamicbase");
}
// FIXME #16514: ASLR is disabled on Windows due to MinGW-w64 bugs:
// FIXME #17098: ASLR breaks gdb on Windows
// FIXME #17684: ASLR breaks thread-local storage on Windows
//cmd.arg("-Wl,--dynamicbase");

// Mark all dynamic libraries and executables as compatible with the larger 4GiB address
// space available to x86 Windows binaries on x86_64.
Expand Down