Remove cat_discr #17978
Merged
Remove cat_discr #17978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
r? @nikomatsakis or @pnkfelix |
|
I think you are correct, we don't need this anymore. I would like @pnkfelix to confirm though that he didn't repurpose this in some way for the fragment computation stuff he is working on --- but iirc he only touched |
|
r+ pending clarification on why match cases were moved around. I just want to be sure that this wasn't prompted by some new error (which I wouldn't expect, but...) |
|
Just remove some junk. The match cases were moved around so that the compiler can prove they are exhaustive. |
|
ping @arielb1, looks like a test failure |
arielb1
force-pushed
the
remaining-garbage
branch
from
a1e2162
to
436fb52
Compare
arielb1
force-pushed
the
remaining-garbage
branch
from
436fb52
to
19faaf1
Compare
bors
added a commit
that referenced
this pull request
Oct 27, 2014
it seems to be some kind of leftover GC-related detritus
it seems to be some kind of GC-related mess
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Sep 25, 2024
…=Veykril Do not report missing unsafe on `addr_of[_mut]!(EXTERN_OR_MUT_STATIC)` The compiler no longer does as well; see rust-lang#125834. Also require unsafe when accessing `extern` `static` (other than by `addr_of!()`). Fixes rust-lang#17978.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems to be some kind of leftover GC-related detritus