Allow #[linkage] on any statics not just foreign statics. #18890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| } | ||
| _ => {} |
There was a problem hiding this comment.
This allows #[linkage] on any item, right? I suppose it's ok behind a feature gate, but I'm not sure how much sense it makes to put this on a function, but who knows!
|
I do think that this shouldn't be the only way to control the linkage of a static, it should be declared as Could you add a test for this? Both for the linkage working as well as a test that it's feature gated? |
… it's processed during trans.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 20, 2025
minor: Fixup macro error kinds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially useful for declaring a static with external linkage in an executable. There isn't any way to do that currently since we mark everything in an executable as internal by default.
Also, a quick fix to have the no-compiler-rt target option respected when building staticlibs as well.