Rename unwrap functions to into_inner #19149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -257,11 +257,15 @@ impl<T> RefCell<T> { | |||
|
|
|||
| /// Consumes the `RefCell`, returning the wrapped value. | |||
| #[unstable = "may be renamed, depending on global conventions"] | |||
There was a problem hiding this comment.
Can you adjust this comment to say: "recently renamed per RFC 430"?
|
r=me modulo stability nit. |
|
BTW this should close #13159 |
alexcrichton
force-pushed
the
issue-19091
branch
2 times, most recently
from
9d4b10e
to
c6b651b
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 22, 2014
This change applies the conventions to unwrap listed in [RFC 430][rfc] to rename non-failing `unwrap` methods to `into_inner`. This is a breaking change, but all `unwrap` methods are retained as `#[deprecated]` for the near future. To update code rename `unwrap` method calls to `into_inner`. [rfc]: rust-lang/rfcs#430 [breaking-change] Closes rust-lang#13159 cc rust-lang#19091
alexcrichton
force-pushed
the
issue-19091
branch
from
c6b651b
to
f1f6c12
Compare
bors
added a commit
that referenced
this pull request
Nov 25, 2014
This change applies the conventions to unwrap listed in [RFC 430][rfc] to rename non-failing `unwrap` methods to `into_inner`. This is a breaking change, but all `unwrap` methods are retained as `#[deprecated]` for the near future. To update code rename `unwrap` method calls to `into_inner`. [rfc]: rust-lang/rfcs#430 [breaking-change] cc #19091
CryZe
added a commit
to CryZe/rust
that referenced
this pull request
Sep 21, 2016
A long time ago non-panicking `unwrap` methods were renamed to `into_inner` in this Pull Request: rust-lang#19149 Looks like this doc comment was not updated however.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Sep 22, 2016
Fix outdated Doc Comment on BufReader::seek A long time ago non-panicking `unwrap` methods were renamed to `into_inner` in this Pull Request: rust-lang#19149 Looks like this doc comment was not updated however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies the conventions to unwrap listed in RFC 430 to rename
non-failing
unwrapmethods tointo_inner. This is a breaking change, but allunwrapmethods are retained as#[deprecated]for the near future. To updatecode rename
unwrapmethod calls tointo_inner.[breaking-change]
cc #19091