Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gcc-less installation on Windows #19604

Closed
wants to merge 2 commits into from

Conversation

vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Dec 6, 2014

  • Support gcc-less installation on Windows. To do so in unattended mode run:<intaller>.exe /TYPE=compact /SILENT.
  • Do not require admin privileges to install.

cc #19519

…de run:`<intaller>.exe /TYPE=compact /SILENT`.

- Do not require admin privileges to install.
@alexcrichton
Copy link
Member

r? @brson

@vadimcn, do you have a copy of the installer that I'd be able to test out locally as well?

@vadimcn
Copy link
Contributor Author

vadimcn commented Dec 8, 2014

@brson
Copy link
Contributor

brson commented Dec 8, 2014

Thanks @vadimcn

@alexcrichton
Copy link
Member

@vadimcn I ran this installer locally and noticed a few things:

  • I could never uncheck "Rust compiler and standard libraries", just checking this is intentional, right?
  • I got an error: "CreateFile failed; code 5. Access is denied". Is this because I'm not installing with administrator privileges, but my previous installation was installed with admin privileges?
  • Upon deleting my existing C:\Program Files (x86)\Rust folder, I got the error "Setup was unable to create the directory ..." and I was unable to install.
  • I was initially prompted with a prompt to elevate privileges, but I couldn't reproduce this, it may have been related to my previous installation existing.

@vadimcn
Copy link
Contributor Author

vadimcn commented Dec 8, 2014

Uh-huh, I never install Rust into "Program Files", so I didn't notice that problem. I guess I am gonna have to revert the "Do not require admin privileges to install" bit. Which is a pity, because that precludes non-admins from installing it.

@alexcrichton
Copy link
Member

I'd actually love to keep the ability to not require admin privileges! Is there a way to default to a different folder which doesn't require admin privileges?

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 9, 2014
- Support gcc-less installation on Windows.  To do so in unattended mode run:`<intaller>.exe /TYPE=compact /SILENT`.
- Do not require admin privileges to install.

cc rust-lang#19519
@vadimcn
Copy link
Contributor Author

vadimcn commented Dec 10, 2014

re-r+ ?

@alexcrichton
Copy link
Member

@vadimcn hm I thought I included this in the rollup? Does the new commit mean that each installation of rust is placed in a new directory?

@vadimcn
Copy link
Contributor Author

vadimcn commented Dec 10, 2014

hm I thought I included this in the rollup?

Was it? Hmm, this PR is still open. Should I open a new one?

Does the new commit mean that each installation of rust is placed in a new directory?

Not every time, but it'll include version number and release channel, like so: C:\Rust-0.13.0-dev. Do you want something more stable?

@alexcrichton
Copy link
Member

Rollup PRs only actually get closed if the HEAD is the same when its merged as when I merged it locally, so you may have pushed after I made the rollup (that's ok). It does mean that at least some portions of this PR are currently in master.

I only worry because it's different than all our other platforms. I personally only want to overwrite the previous installation, but I know that people may differ! Perhaps an option could be provided?

@vadimcn vadimcn closed this Dec 10, 2014
@vadimcn vadimcn deleted the gcc-less branch March 1, 2015 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants