Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wrapper structs for iterators in BTreeMap/Set and HashMap/Set #19770

Merged
merged 4 commits into from
Dec 17, 2014
Merged

Use wrapper structs for iterators in BTreeMap/Set and HashMap/Set #19770

merged 4 commits into from
Dec 17, 2014

Commits on Dec 16, 2014

  1. Use wrapper structs for BTreeMap's iterators. 

    Using a type alias for iterator implementations is fragile since this
exposes the implementation to users of the iterator, and any changes
could break existing code.

This commit changes the keys and values iterators of `BTreeMap` to use
proper new types, rather than type aliases.  However, since it is
fair-game to treat a type-alias as the aliased type, this is a:

[breaking-change].
    @csouth3
    csouth3 committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    765806e View commit details
    Browse the repository at this point in the history

  2. Use wrapper structs for BTreeSet's iterators. 

    Using a type alias for iterator implementations is fragile since this
exposes the implementation to users of the iterator, and any changes
could break existing code.

This commit changes the iterators of `BTreeSet` to use
proper new types, rather than type aliases.  However, since it is
fair-game to treat a type-alias as the aliased type, this is a:

[breaking-change].
    @csouth3
    csouth3 committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    a81c3ab View commit details
    Browse the repository at this point in the history

  3. Use wrapper structs for HashMap's iterators. 

    Using a type alias for iterator implementations is fragile since this
exposes the implementation to users of the iterator, and any changes
could break existing code.

This commit changes the keys and values iterators of `HashMap` to use
proper new types, rather than type aliases.  However, since it is
fair-game to treat a type-alias as the aliased type, this is a:

[breaking-change].
    @csouth3
    csouth3 committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    85fe141 View commit details
    Browse the repository at this point in the history

  4. Use wrapper structs for HashSet's iterators. 

    Using a type alias for iterator implementations is fragile since this
exposes the implementation to users of the iterator, and any changes
could break existing code.

This commit changes the iterators of `HashSet` to use
proper new types, rather than type aliases.  However, since it is
fair-game to treat a type-alias as the aliased type, this is a:

[breaking-change].
    @csouth3
    csouth3 committed Dec 16, 2014
    Configuration menu
    Copy the full SHA
    341cf40 View commit details
    Browse the repository at this point in the history