InvariantLifetime is Copy-able #19838
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
InvariantLifetime is Copy-able Reviewed-by: alexcrichton
InvariantLifetime is Copy-able Reviewed-by: alexcrichton
Using a type alias for iterator implementations is fragile since this exposes the implementation to users of the iterator, and any changes could break existing code. This commit changes the iterators of `VecMap` to use proper new types, rather than type aliases. However, since it is fair-game to treat a type-alias as the aliased type, this is a: [breaking-change].
InvariantLifetime is Copy-able Reviewed-by: alexcrichton
Both ContravariantLifetime and CovariantLifetime are marked as Copy, so it makes sense for InvariantLifetime to be as well.
InvariantLifetime is Copy-able Reviewed-by: alexcrichton
|
@alexcrichton @shepmaster considering #19913 wouldn't it be more consistent to use |
|
@vhbit I think your link isn't quite right... |
|
@shepmaster hmm, sorry, seems I've copied the wrong one, I've meant #19867 |
Both ContravariantLifetime and CovariantLifetime are marked as Copy, so it makes sense for InvariantLifetime to be as well.
|
Hmm, it probably would make more sense. I'll go ahead and change mine, seeing as how the other PR has traction. |
shepmaster
force-pushed
the
invariant-lifetime-copy
branch
from
5966815
to
1dad206
Compare
|
@alexcrichton modified to use |
|
Ah sorry this ended up already getting merged into the rollup, could you rebase to delete the manual |
shepmaster
force-pushed
the
invariant-lifetime-copy
branch
from
1dad206
to
1afa8ac
Compare
|
@alexcrichton done and done! Thanks for getting this in for me; maybe my Travis builds will build now :-) |
|
Thanks! |
InvariantLifetime is Copy-able Reviewed-by: alexcrichton
Both ContravariantLifetime and CovariantLifetime are marked as Copy, so it makes sense for InvariantLifetime to be as well.
Both ContravariantLifetime and CovariantLifetime are marked as Copy,
so it makes sense for InvariantLifetime to be as well.