Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a ton of public reexports #19842

Closed
wants to merge 1 commit into from
Closed

Remove a ton of public reexports #19842

wants to merge 1 commit into from

Conversation

frewsxcv
Copy link
Member

Remove most of the public reexports mentioned in #19253

These are all leftovers from the enum namespacing transition

In particular:

  • src/libstd/num/strconv.rs
    • ExponentFormat
    • SignificantDigits
    • SignFormat
  • src/libstd/path/windows.rs
    • PathPrefix
  • src/libstd/sys/windows/timer.rs
    • Req
  • src/libcollections/str.rs
    • MaybeOwned
  • src/libstd/collections/hash/map.rs
    • Entry
  • src/libstd/collections/hash/table.rs
    • BucketState
  • src/libstd/dynamic_lib.rs
    • Rtld
  • src/libstd/os.rs
    • MemoryMapKind
    • MapOption
    • MapError
  • src/libstd/sys/common/net.rs
    • SocketStatus
    • InAddr
  • src/libstd/sys/unix/timer.rs
    • Req

[breaking-change]

@frewsxcv frewsxcv force-pushed the rm-reexports branch 7 times, most recently from c19d189 to d568933 Compare December 17, 2014 01:39
@alexcrichton
Copy link
Member

In the interest of less churn, would it be ok to leave out std::io for now? I expect rust-lang/rfcs#517 to handle most of the removal of reexports in the std::io module.

Thanks for this!

@frewsxcv
Copy link
Member Author

In the interest of less churn, would it be ok to leave out std::io for now?

@alexcrichton Sorry, I'm a little confused about what you mean. Do you meant that I should remove all the changes for the std::io files (in which case tests wouldn't compile pass) or that I should readd the reexports?

@frewsxcv frewsxcv force-pushed the rm-reexports branch 8 times, most recently from e3aeb66 to c18f759 Compare December 20, 2014 04:53
@frewsxcv
Copy link
Member Author

@alexcrichton Removing all std::io changes ended up being pretty trivial. How does it look now?

@alexcrichton
Copy link
Member

Could you also roll back the fall out from the std::io changes? There's a few things that are accessing FileMode::Open for example when they can just be using Open.

@frewsxcv
Copy link
Member Author

Okay, how about that?

@frewsxcv frewsxcv force-pushed the rm-reexports branch 2 times, most recently from e602f7a to 6c8c287 Compare December 20, 2014 18:19
@alexcrichton
Copy link
Member

Thanks @frewsxcv!

@frewsxcv
Copy link
Member Author

Just fixed an issue from a recent merge into master

@frewsxcv
Remove a ton of public reexports
5fe6fc5 
Remove most of the public reexports mentioned in rust-lang#19253

These are all leftovers from the enum namespacing transition

In particular:

* src/libstd/num/strconv.rs
 * ExponentFormat
 * SignificantDigits
 * SignFormat
* src/libstd/path/windows.rs
 * PathPrefix
* src/libstd/sys/windows/timer.rs
 * Req
* src/libcollections/str.rs
 * MaybeOwned
* src/libstd/collections/hash/map.rs
 * Entry
* src/libstd/collections/hash/table.rs
 * BucketState
* src/libstd/dynamic_lib.rs
 * Rtld
* src/libstd/io/net/ip.rs
 * IpAddr
* src/libstd/os.rs
 * MemoryMapKind
 * MapOption
 * MapError
* src/libstd/sys/common/net.rs
 * SocketStatus
 * InAddr
* src/libstd/sys/unix/timer.rs
 * Req

[breaking-change]
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 21, 2014
@alexcrichton
rollup merge of rust-lang#19842: frewsxcv/rm-reexports
25f8051 
Remove most of the public reexports mentioned in rust-lang#19253

These are all leftovers from the enum namespacing transition

In particular:

* src/libstd/num/strconv.rs
 * ExponentFormat
 * SignificantDigits
 * SignFormat
* src/libstd/path/windows.rs
 * PathPrefix
* src/libstd/sys/windows/timer.rs
 * Req
* src/libcollections/str.rs
 * MaybeOwned
* src/libstd/collections/hash/map.rs
 * Entry
* src/libstd/collections/hash/table.rs
 * BucketState
* src/libstd/dynamic_lib.rs
 * Rtld
* src/libstd/os.rs
 * MemoryMapKind
 * MapOption
 * MapError
* src/libstd/sys/common/net.rs
 * SocketStatus
 * InAddr
* src/libstd/sys/unix/timer.rs
 * Req

[breaking-change]
@alexcrichton
Copy link
Member

This was rolled into #20104

@frewsxcv frewsxcv deleted the rm-reexports branch December 22, 2014 17:54
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 22, 2014
@frewsxcv
Remove cmp::Ordering::* public reexport
02feaf2 
Part of rust-lang#19253

I would have removed this public reexport in rust-lang#19842, but rust-lang#19812 hadn't merged (and snapshotted) at the time

In rust-lang#19407, I changed the codebase to stop utilizing this reexport

[breaking-change]
@frewsxcv frewsxcv mentioned this pull request Dec 22, 2014
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 22, 2014
@alexcrichton
rollup merge of rust-lang#20140: frewsxcv/rm-reexports
fac17de 
Part of rust-lang#19253

I would have removed this public reexport in rust-lang#19842, but rust-lang#19812 hadn't merged (and snapshotted) at the time

In rust-lang#19407, I changed the codebase to stop utilizing this reexport

[breaking-change]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frewsxcv @alexcrichton