Minor changes to Rust Language FAQ #19856
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
iKevinY
changed the title
|
Thank you! |
Minor changes to Rust Language FAQ Reviewed-by: steveklabnik
Using a type alias for iterator implementations is fragile since this exposes the implementation to users of the iterator, and any changes could break existing code. This commit changes the iterators of `VecMap` to use proper new types, rather than type aliases. However, since it is fair-game to treat a type-alias as the aliased type, this is a: [breaking-change].
Minor changes to Rust Language FAQ Reviewed-by: steveklabnik
- Change long inline code to code block - Replace double-hyphens with en dash - Miscellaneous rephrasings for clarity **Edit**: Trivial `commit --amend` to change the commit message slightly.
Minor changes to Rust Language FAQ Reviewed-by: steveklabnik
| For a full description see [the logging crate][1]. | ||
| debugging linking in the compiler, you might set the following: | ||
|
|
||
| RUST_LOG=rustc::metadata::creader,rustc::util::filesearch,rustc::back::rpath |
There was a problem hiding this comment.
Looks like this line caused a test to fail in the rollup. Maybe the culprit is the removed backticks?
There was a problem hiding this comment.
should probably be triple grave bash, or text.
There was a problem hiding this comment.
Ah, I'll fix this. It seemed to generate properly previously when running make docs so I figured it was alright.
Edit: Updated the PR to use the triple-backtick markup and rebased.
- Change long inline code to code block - Replace double-hyphens with en dash - Miscellaneous rephrasings for clarity
|
@csouth3 @steveklabnik Does this look better? |
|
Thanks! |
- Change long inline code to code block - Replace double-hyphens with en dash - Miscellaneous rephrasings for clarity **Edit**: Trivial `commit --amend` to change the commit message slightly.
Edit: Trivial
commit --amendto change the commit message slightly.