Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free stdin on exit #19869

Merged
merged 1 commit into from
Dec 17, 2014
Merged

Free stdin on exit #19869

merged 1 commit into from
Dec 17, 2014

Conversation

sfackler
Copy link
Member

r? @aturon

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

bors added a commit that referenced this pull request Dec 16, 2014
Free stdin on exit

Reviewed-by: aturon
bors referenced this pull request Dec 16, 2014
Using a type alias for iterator implementations is fragile since this
exposes the implementation to users of the iterator, and any changes
could break existing code.

This commit changes the iterators of `VecMap` to use
proper new types, rather than type aliases.  However, since it is
fair-game to treat a type-alias as the aliased type, this is a:

[breaking-change].
bors added a commit that referenced this pull request Dec 16, 2014
Free stdin on exit

Reviewed-by: aturon
bors referenced this pull request Dec 16, 2014
This creates an enormous amount of spew.
bors added a commit that referenced this pull request Dec 17, 2014
Free stdin on exit

Reviewed-by: aturon
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 17, 2014
@bors bors merged commit 8d6895a into rust-lang:master Dec 17, 2014
@sfackler sfackler deleted the free-stdin branch November 26, 2016 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants