Small cleanups in HashMap based off of new rust features. #19935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Full(bucket) => bucket | ||
| }; | ||
|
|
||
| if bucket.hash() == hash { | ||
| let found_match = { |
There was a problem hiding this comment.
minor concern that we're losing some semantics here
There was a problem hiding this comment.
In isolation, we've replaced the helpful name found_match with some more opaque if statement.
There was a problem hiding this comment.
I can add a comment.
|
r=me with squash |
cgaebel
force-pushed
the
hashmap-tuple-indexing
branch
from
4bb2a5b
to
c42e2f6
Compare
|
|
bors
added a commit
that referenced
this pull request
Dec 17, 2014
Small cleanups in HashMap based off of new rust features. Reviewed-by: Gankro
bors
referenced
this pull request
Dec 17, 2014
Using a type alias for iterator implementations is fragile since this exposes the implementation to users of the iterator, and any changes could break existing code. This commit changes the iterators of `VecMap` to use proper new types, rather than type aliases. However, since it is fair-game to treat a type-alias as the aliased type, this is a: [breaking-change].
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @gankro @pczarn