test: Move some tests to scoped instead of spawn #20704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests have all been failing spuroiusly on Windows from time to time, and one suspicion is that the shilc thread outliving the main thread somehow causes the problem. Switch all the tests over to using Thread::scoped instead of Thread::spawn to see if it helps the issue. cc rust-lang#19120
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -42,7 +42,7 @@ fn count(n: libc::uintptr_t) -> libc::uintptr_t { | |||
|
|
|||
| pub fn main() { | |||
| range(0u, 100).map(|_| { | |||
| Thread::spawn(move|| { | |||
| Thread::scoped(move|| { | |||
There was a problem hiding this comment.
Note: this means the threads don't actually run concurrently.
|
Nevermind! I clearly wasn't paying enough attention. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 8, 2015
…ss-spurious These tests have all been failing spuroiusly on Windows from time to time, and one suspicion is that the shilc thread outliving the main thread somehow causes the problem. Switch all the tests over to using Thread::scoped instead of Thread::spawn to see if it helps the issue. cc rust-lang#19120
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jul 22, 2016
Long ago we discovered that threads which outlive main and then exit while the rest of the program is exiting causes Windows to hang (rust-lang#20704). That's what was happening in this test so let's just not run this test any more.
bors
added a commit
that referenced
this pull request
Jul 26, 2016
std: Ignore tests where threads outlive main Long ago we discovered that threads which outlive main and then exit while the rest of the program is exiting causes Windows to hang (#20704). That's what was happening in this test so let's just not run this test any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests have all been failing spuroiusly on Windows from time to time, and
one suspicion is that the shilc thread outliving the main thread somehow causes
the problem. Switch all the tests over to using Thread::scoped instead of
Thread::spawn to see if it helps the issue.
cc #19120