Rollup of 13 pull requests #21582
Merged
Rollup of 13 pull requests #21582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e child panics before passing.
… directory's name, and remove the directory after a successful test.
Also makes errorck.py and tidy.py compatible with Python 3.
While trying to experiment with changes for some other issues, I noticed that the test for rust-lang#15149 was failing because I have `/tmp` mounted as `noexec` on my Linux box, and that test tries to run out of a temporary directory. This may not be the most common case, but it's not rare by any means, because executing from a world-writable directory is a security problem. (For this reason, some kernel options/mods such as grsecurity also can prevent this on Linux.) I instead copy the executable to a directory created in the build tree, following the example of the `process-spawn-with-unicode-params` test. After I made that change, I noticed that I'd made a mistake, but the test was still passing, because the "parent" process was not actually checking the status of the "child" process, meaning that the assertion in the child could never cause the overall test to fail. (I don't know if this has always been the case, or if it has something to do with either Windows or a change in the semantics of `spawn`.) So I fixed the test so that it would fail correctly, then fixed my original mistake so that it would pass again. The one big problem with this is that I haven't set up any machines of my own so that I can build on Windows, which is the platform this test was targeted at in the first place! That might take a while to address on my end. So I need someone else to check this on Windows.
…=alexcrichton Fix for `error: functions used as tests must have signature fn() -> ()` and `error: functions used as benches must have signature `fn(&mut Bencher) -> ()` in case of explicit return type declaration.
Fixes rust-lang#19759 I'm not going to bother to do more than this, as it'll end up getting re-done as part of the reference work, but at least it's correct now.
Also makes `errorck.py` and `tidy.py` compatible with Python 3.
…=sanxiyn We've had some new people post questions to Discuss, so this should be removed for now. http://discuss.rust-lang.org/t/did-you-mean-to-point-to-discuss-rust-lang-org-as-a-user-forum/1381
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @huonw |
|
@bors: r+ 38cb4 p=1 |
|
🙀 You have the wrong number! Please try again with |
|
@bors: r+ 8d40f0 p=1 |
|
⌛ Testing commit 8d40f0f with merge 23bb8ad... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: r+ 577c p=1 |
|
⌛ Testing commit 577c464 with merge 51f5b64... |
|
💔 Test failed - auto-win-64-nopt-t |
…ontains the full path
|
👍 rollups rule |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[rustc_on_unimplemented]annotations to more traits #21445, Fix #15149 test, and allow it to run with noexec /tmp on POSIX systems. #21498, libsyntax: fix forhas_test_signature#21504, remove weird sentence #21532, Fix up lang items in the reference #21535, Makemake tidyPython scripts more idiomatic #21539, Language tweak in configure #21540, Check for make in configure #21541, Fix compile test for stage0 #21550, remove discuss link from the book #21560, add test for issue 19660 #21573, Fix beta naming #21579