Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message, when found staticlib instead crate #21978

Merged
merged 1 commit into from
Feb 7, 2015
Merged

Improve error message, when found staticlib instead crate #21978

merged 1 commit into from
Feb 7, 2015

Conversation

Potpourri
Copy link
Contributor

Add special error for this case and help message please recompile this crate using --crate-type lib, also list found candidates.

See issue #14416

r? @alexcrichton

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

@bors: r+ 8e3df86

Thanks!

bors added a commit that referenced this pull request Feb 7, 2015
…crichton

Add special error for this case and help message `please recompile this crate using --crate-type lib`, also list found candidates.

See issue #14416

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Feb 7, 2015

⌛ Testing commit 8e3df86 with merge e62fec3...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants