Replace uint by usize in libcore/panicking.rs #22507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
40 tasks
|
I suspect most of these should be |
| @@ -34,25 +34,25 @@ use fmt; | |||
|
|
|||
| #[cold] #[inline(never)] // this is the slow path, always | |||
| #[lang="panic"] | |||
| pub fn panic(expr_file_line: &(&'static str, &'static str, uint)) -> ! { | |||
| pub fn panic(expr_file_line: &(&'static str, &'static str, usize)) -> ! { | |||
There was a problem hiding this comment.
This should be either u32 or u64, you could make an argument for either -- I'd suggest u64 based on the maximum file length we report and the lack of performance issues here.
|
I was speaking with @aturon about the argument size, I was more for u32 but u64 seems better. |
|
cc #22240 |
Conflicts: src/libcore/panicking.rs
Conflicts: src/libcore/panicking.rs
|
I believe this actually ended up getting taken care of in #22853 actually, but thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #22240.