Deprecate range, range_step, count, distributions #23347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 especially re the new adapter |
| @@ -1387,7 +1387,7 @@ fn merge_sort<T, F>(v: &mut [T], mut compare: F) where F: FnMut(&T, &T) -> Order | |||
| // We could hardcode the sorting comparisons here, and we could | |||
| // manipulate/step the pointers themselves, rather than repeatedly | |||
| // .offset-ing. | |||
| for start in range_step(0, len, insertion) { | |||
| for start in (0.. len).step_by(insertion) { | |||
|
|
||
| /// Creates a new counter with the specified start/step | ||
| #[inline] | ||
| #[unstable(feature = "core", | ||
| reason = "may be renamed or replaced by range notation adapters")] | ||
| #[deprecated(since = "1.0.0-beta", reason = "use range notation and step_by")] |
There was a problem hiding this comment.
I find it also helpful if the error message says something like "replace count(a, b) with (0..).step_by(b)" just so it's easy to know how to convert
|
Nice! r=me with just a few nits |
|
@bors: r=alexcrichton 1337291 |
aturon
force-pushed
the
stab-misc
branch
2 times, most recently
from
bcf57d0
to
1d5983a
Compare
This commit deprecates the `count`, `range` and `range_step` functions in `iter`, in favor of range notation. To recover all existing functionality, a new `step_by` adapter is provided directly on `ops::Range` and `ops::RangeFrom`. [breaking-change]
|
⌛ Testing commit 1d5983a with merge 2b6af65... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry On Sat, Mar 14, 2015 at 7:58 AM, bors notifications@github.com wrote:
|
|
⌛ Testing commit 1d5983a with merge 7a306b1... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Mar 16, 2015
This commit deprecates the `count`, `range` and `range_step` functions in `iter`, in favor of range notation. To recover all existing functionality, a new `step_by` adapter is provided directly on `ops::Range` and `ops::RangeFrom`. [breaking-change] r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deprecates the
count,rangeandrange_stepfunctionsin
iter, in favor of range notation. To recover all existingfunctionality, a new
step_byadapter is provided directly onops::Rangeand
ops::RangeFrom.[breaking-change]
r? @alexcrichton