-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make note of str in 'more strings' chapter #23639
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ 211eb3c |
@bors: rollup |
@bors: r=alexcrichton rollup |
📌 Commit 1be8fcb has been approved by |
(apparently I need to triple check issue numbers, that's the second typo today :/) |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Mar 23, 2015
Fixes rust-lang#21305 Not sure if we should include more than this here, but it should be good to have at least this.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2015
Fixes rust-lang#21305 Not sure if we should include more than this here, but it should be good to have at least this.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 23, 2015
- Successful merges: rust-lang#22954, rust-lang#23119, rust-lang#23509, rust-lang#23561, rust-lang#23590, rust-lang#23607, rust-lang#23608, rust-lang#23618, rust-lang#23622, rust-lang#23639, rust-lang#23641 - Failed merges: rust-lang#23401
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 24, 2015
Fixes rust-lang#21305 Not sure if we should include more than this here, but it should be good to have at least this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21305
Not sure if we should include more than this here, but it should be good to have at least this.