Make Copy a subtrait of Clone #23860

nikomatsakis · 2015-03-30T13:37:05Z

Logically, Copy: Clone makes sense, since Copy basically means "I can clone this with just memcpy". This also means that one can start out with a Copy bound and relax it to a Clone bound.

This is a [breaking-change] because one must change #[derive(Copy)] to #[derive(Copy,Clone)]. In some cases, deriving doesn't create a proper clone impl (notably around fixed-length arrays), in which case you should write one by hand. Because the type in question is Copy, this is very simple:

impl Clone for Foo { fn clone(&self) -> Foo { *self } }

Fixes #23790.

r? @aturon (stabilization issue)

pnkfelix · 2015-03-30T13:57:41Z

src/test/run-pass/guards-not-exhaustive.rs

@@ -8,10 +8,18 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.

+<<<<<<< HEAD


this can't be right.

I would guess not

aturon · 2015-03-30T16:32:35Z

r=me once bad merge is resolved.

bors · 2015-03-30T17:20:08Z

☔ The latest upstream changes (presumably #23673) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2015-03-30T19:32:24Z

Created a discuss thread about this PR http://internals.rust-lang.org/t/making-copy-a-subtrait-of-clone-pr-23860/1777

theemathas · 2015-03-31T01:24:56Z

I have always assumed that Copy was not a subtrait of Clone because of &T.

Turns out that &T is both Copy and Clone, after all.

👍 😃

nikomatsakis · 2015-03-31T08:46:22Z

@bors r=aturon 32b6ec6

nikomatsakis · 2015-03-31T08:46:41Z

oh, needs merge.

bors · 2015-03-31T18:29:48Z

☔ The latest upstream changes (presumably #23549) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2015-04-01T15:19:36Z

@bors r= aturon 1b5ac16

bors · 2015-04-01T15:19:38Z

📌 Commit 1b5ac16 has been approved by ``

nikomatsakis · 2015-04-01T15:20:18Z

@bors r=aturon 1b5ac16

nikomatsakis · 2015-04-01T15:24:11Z

@bors r=aturon c35c468

Manishearth · 2015-04-01T15:47:34Z

Would this bloat crate size for crates that derive Copy on exported types but not Clone?

I'm also a bit concerned if this affects #![no_std] since Copy is a lang item.

nikomatsakis · 2015-04-01T16:49:49Z

@bors r=aturon 943729f

Manishearth · 2015-04-01T19:04:27Z

http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/3983 ?

nikomatsakis · 2015-04-01T19:57:29Z

@Manishearth that should be fixed by the most recent push.

bors · 2015-04-02T01:35:57Z

☔ The latest upstream changes (presumably #23955) made this pull request unmergeable. Please resolve the merge conflicts.

Conflicts: src/test/compile-fail/coherence-impls-copy.rs

alexcrichton · 2015-04-02T01:54:06Z

gah I missed this in the rollup!

As per rust-lang/rust#23860, Copy now extends Clone. Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Fixes for change introduced by rust-lang/rust#23860

Swap order of input and output parameters of ptr::copy_nonoverlapping (rust-lang/rust#23866), remove usage of std::num::Int (rust-lang/rust#23549), change (rust-lang/rust#23860).

Fixes for change introduced by rust-lang/rust#23860

rust-highfive assigned aturon Mar 30, 2015

nikomatsakis mentioned this pull request Mar 30, 2015

make Copy: Clone #23790

Closed

nikomatsakis force-pushed the copy-requires-clone branch from e340206 to a608750 Compare March 30, 2015 13:41

pnkfelix reviewed Mar 30, 2015
View reviewed changes

nikomatsakis force-pushed the copy-requires-clone branch from f081d19 to eb8315a Compare March 30, 2015 18:44

nikomatsakis force-pushed the copy-requires-clone branch from eb8315a to 32b6ec6 Compare March 30, 2015 20:25

nikomatsakis force-pushed the copy-requires-clone branch from 32b6ec6 to a758cf5 Compare March 31, 2015 08:47

erickt mentioned this pull request Mar 31, 2015

Make #[derive(Copy, Eq, Ord)] imply #[derive(Clone, PartialEq, PartialOrd)] #23905

Closed

nikomatsakis force-pushed the copy-requires-clone branch from a758cf5 to 1b5ac16 Compare April 1, 2015 15:19

nikomatsakis added 5 commits April 1, 2015 11:22

Make the trait Copy extend Clone.

c4edd0c

Fallout in tests

890ed5c

Fallout out rustc

d9530c0

Fallout in libsyntax

49b76a0

Fallout in public-facing and semi-public-facing libs

c35c468

nikomatsakis force-pushed the copy-requires-clone branch from 1b5ac16 to c35c468 Compare April 1, 2015 15:23

Missing imports

943729f

Manishearth mentioned this pull request Apr 1, 2015

Rollup of 9 pull requests #23946

Closed

Fix enum timezone across all platforms.

4496433

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 2, 2015

rollup merge of rust-lang#23860: nikomatsakis/copy-requires-clone

f92e7ab

Conflicts: src/test/compile-fail/coherence-impls-copy.rs

bors merged commit 4496433 into rust-lang:master Apr 2, 2015

semarie mentioned this pull request Apr 2, 2015

libc: unbreak severals os/platform #23967

Merged

alexcrichton mentioned this pull request Apr 2, 2015

Automatically derive {Clone,PartialEq,PartialOrd} when {Copy,Eq,Ord} are derived rust-lang/rfcs#1028

Closed

andersk added a commit to andersk/image-rs that referenced this pull request Apr 3, 2015

Derive Clone when deriving Copy

ef044ab

As per rust-lang/rust#23860, Copy now extends Clone. Signed-off-by: Anders Kaseorg <andersk@mit.edu>

CraZySacX mentioned this pull request Apr 3, 2015

Fd ist now RawFd (rustup) nix-rust/nix#92

Merged

andersk added a commit to andersk/image-rs that referenced this pull request Apr 3, 2015

Derive Clone when deriving Copy

ea58de3

As per rust-lang/rust#23860, Copy now extends Clone. Signed-off-by: Anders Kaseorg <andersk@mit.edu>

DaGenix added a commit to DaGenix/rust-crypto that referenced this pull request Apr 4, 2015

Merge pull request #290 from rustyhorde/master

734248d

Fixes for change introduced by rust-lang/rust#23860

zmack mentioned this pull request Apr 5, 2015

Compatibility with rust latest nix-rust/nix#94

Closed

justinlatimer mentioned this pull request Apr 7, 2015

Derive Clone trait for Stopwatch ellisonch/rust-stopwatch#3

Merged

jooert mentioned this pull request Apr 29, 2015

Update code to compile with latest rustc. andydude/rust-bswap#6

Closed

mitaa mentioned this pull request Jul 13, 2015

Ownership error masks missing implementation of trait #27009

Closed

nikomatsakis deleted the copy-requires-clone branch March 30, 2016 16:12

BlockBlazeDev added a commit to BlockBlazeDev/rust-crypto that referenced this pull request Aug 8, 2024

Fixes for rust-lang/rust#23860

856511c

BlockBlazeDev added a commit to BlockBlazeDev/rust-crypto that referenced this pull request Aug 8, 2024

Fixes for rust-lang/rust#23860

ca5a652

BlockBlazeDev added a commit to BlockBlazeDev/rust-crypto that referenced this pull request Aug 8, 2024

Merge pull request #290 from rustyhorde/master

132bf7d

Fixes for change introduced by rust-lang/rust#23860

cosmycoder added a commit to cosmycoder/rust-crypto that referenced this pull request Sep 5, 2024

Fixes for rust-lang/rust#23860

9b36825

cosmycoder added a commit to cosmycoder/rust-crypto that referenced this pull request Sep 5, 2024

Fixes for rust-lang/rust#23860

67a023e

cosmycoder added a commit to cosmycoder/rust-crypto that referenced this pull request Sep 5, 2024

Merge pull request #290 from rustyhorde/master

7dd955a

Fixes for change introduced by rust-lang/rust#23860

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Copy a subtrait of Clone #23860

Make Copy a subtrait of Clone #23860

nikomatsakis commented Mar 30, 2015

pnkfelix Mar 30, 2015

nikomatsakis Mar 30, 2015

aturon commented Mar 30, 2015

bors commented Mar 30, 2015

nikomatsakis commented Mar 30, 2015

theemathas commented Mar 31, 2015

nikomatsakis commented Mar 31, 2015

nikomatsakis commented Mar 31, 2015

bors commented Mar 31, 2015

nikomatsakis commented Apr 1, 2015

bors commented Apr 1, 2015

nikomatsakis commented Apr 1, 2015

nikomatsakis commented Apr 1, 2015

Manishearth commented Apr 1, 2015

nikomatsakis commented Apr 1, 2015

Manishearth commented Apr 1, 2015

nikomatsakis commented Apr 1, 2015

bors commented Apr 2, 2015

alexcrichton commented Apr 2, 2015

Make Copy a subtrait of Clone #23860

Make Copy a subtrait of Clone #23860

Conversation

nikomatsakis commented Mar 30, 2015

pnkfelix Mar 30, 2015

Choose a reason for hiding this comment

nikomatsakis Mar 30, 2015

Choose a reason for hiding this comment

aturon commented Mar 30, 2015

bors commented Mar 30, 2015

nikomatsakis commented Mar 30, 2015

theemathas commented Mar 31, 2015

nikomatsakis commented Mar 31, 2015

nikomatsakis commented Mar 31, 2015

bors commented Mar 31, 2015

nikomatsakis commented Apr 1, 2015

bors commented Apr 1, 2015

nikomatsakis commented Apr 1, 2015

nikomatsakis commented Apr 1, 2015

Manishearth commented Apr 1, 2015

nikomatsakis commented Apr 1, 2015

Manishearth commented Apr 1, 2015

nikomatsakis commented Apr 1, 2015

bors commented Apr 2, 2015

alexcrichton commented Apr 2, 2015