-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 3 pull requests #23861
Merged
Merged
Rollup of 3 pull requests #23861
Commits on Mar 27, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 82b375b - Browse repository at this point
Copy the full SHA 82b375bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d77a951 - Browse repository at this point
Copy the full SHA d77a951View commit details -
Rollup merge of rust-lang#23625 - fhahn:issue-23620-ice-unicode-bytes…
…tring, r=alexcrichton closes rust-lang#23620 This PR patches the issue mentioned in rust-lang#23620, but there is also an ICE for invalid escape sequences in byte literals. This is due to the fact that the `scan_byte` function returns ` token::intern(\"??\") ` for invalid bytes, resulting in an ICE later on. Is there a reason for this behavior? Shouldn't `scan_byte` fail when it encounters an invalid byte? And I noticed a small inconsistency in the documentation. According to the formal byte literal definition in http://doc.rust-lang.org/reference.html#byte-and-byte-string-literals , a byte string literal contains `string_body *`, but according to the text (and the behavior of the lexer) it should not accept unicode escape sequences. Hence it should be replaced by `byte_body *`. If this is valid, I can add this fix to this PR.
Configuration menu - View commit details
-
Copy full SHA for e65c6e5 - Browse repository at this point
Copy the full SHA e65c6e5View commit details -
Rollup merge of rust-lang#23712 - nikomatsakis:reflect-trait, r=FlaPer87
This PR introduces a `Reflect` marker trait which is a supertrait of `Any`. The idea is that `Reflect` is defined for all concrete types, but is not defined for type parameters unless there is a `T:Reflect` bound. This is intended to preserve the parametricity property. This allows the `Any` interface to be stabilized without committing us to unbounded reflection that is not easily detectable by the caller. The implementation of `Reflect` relies on an experimental variant of OIBIT. This variant behaves differently for objects, since it requires that all types exposed as part of the object's *interface* are `Reflect`, but isn't concerned about other types that may be closed over. In other words, you don't have to write `Foo+Reflect` in order for `Foo: Reflect` to hold (where `Foo` is a trait). Given that `Any` is slated to stabilization and hence that we are committed to some form of reflection, the goal of this PR is to leave our options open with respect to parametricity. I see the options for full stabilization as follows (I think an RFC would be an appropriate way to confirm whichever of these three routes we take): 1. We make `Reflect` a lang-item. 2. We stabilize some version of the OIBIT variation I implemented as a general mechanism that may be appropriate for other use cases. 3. We give up on preserving parametricity here and just have `impl<T> Reflect for T` instead. In that case, `Reflect` is a harmless but not especially useful trait going forward. cc @aturon cc @alexcrichton cc @glaebhoerl (this is more-or-less your proposal, as I understood it) cc @reem (this is more-or-less what we discussed on IRC at some point) cc @flaper87 (vaguely pertains to OIBIT)
Configuration menu - View commit details
-
Copy full SHA for 5b45ede - Browse repository at this point
Copy the full SHA 5b45edeView commit details -
Rollup merge of rust-lang#23740 - alexcrichton:remove-deprecated-slic…
…ing-syntax, r=aturon This syntax has been deprecated for quite some time, and there were only a few remaining uses of it in the codebase anyway.
Configuration menu - View commit details
-
Copy full SHA for db50084 - Browse repository at this point
Copy the full SHA db50084View commit details
Commits on Mar 30, 2015
-
Configuration menu - View commit details
-
Copy full SHA for d9252bd - Browse repository at this point
Copy the full SHA d9252bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b45470 - Browse repository at this point
Copy the full SHA 3b45470View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.