Remove more mentions of removed keyword priv
#24981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @alexcrichton |
| @@ -96,7 +96,7 @@ priv fn parse_response(io: @io::Reader) -> Result { | |||
| } | |||
| } | |||
|
|
|||
| priv fn cmd_to_string(cmd: ~[String]) -> String { | |||
| fn cmd_to_string(cmd: ~[String]) -> String { | |||
There was a problem hiding this comment.
This file is actually ancient. ~[String] though, that's an anachronism?!
There was a problem hiding this comment.
LOL I didn't even notice that! Maybe I'll take a look around for ~s next :)
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 1, 2015
…lexcrichton Hi! While researching stuff for the reference and the grammar, I came across a few mentions of using the `priv` keyword that was removed in 0.11.0 (rust-lang#13547, rust-lang#8122, rust-lang/rfcs#26, [RFC 0026](https://github.com/rust-lang/rfcs/blob/master/text/0026-remove-priv.md)). One occurrence is a mention in the reference, a few are in comments, and a few are marking test functions. I left the test that makes sure you can't name an ident `priv` since it's still a reserved keyword. I did a little grepping around for `priv `, priv in backticks, `Private` etc and I think the remaining instances are fine, but if anyone knows anywhere in particular I should check for any other lingering mentions of `priv`, please let me know and I would be happy to! 🍂 🌊
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 1, 2015
…lexcrichton Hi! While researching stuff for the reference and the grammar, I came across a few mentions of using the `priv` keyword that was removed in 0.11.0 (rust-lang#13547, rust-lang#8122, rust-lang/rfcs#26, [RFC 0026](https://github.com/rust-lang/rfcs/blob/master/text/0026-remove-priv.md)). One occurrence is a mention in the reference, a few are in comments, and a few are marking test functions. I left the test that makes sure you can't name an ident `priv` since it's still a reserved keyword. I did a little grepping around for `priv `, priv in backticks, `Private` etc and I think the remaining instances are fine, but if anyone knows anywhere in particular I should check for any other lingering mentions of `priv`, please let me know and I would be happy to! 🍂 🌊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! While researching stuff for the reference and the grammar, I came across a few mentions of using the
privkeyword that was removed in 0.11.0 (#13547, #8122, rust-lang/rfcs#26, RFC 0026).One occurrence is a mention in the reference, a few are in comments, and a few are marking test functions. I left the test that makes sure you can't name an ident
privsince it's still a reserved keyword. I did a little grepping around forpriv, priv in backticks,Privateetc and I think the remaining instances are fine, but if anyone knows anywhere in particular I should check for any other lingering mentions ofpriv, please let me know and I would be happy to! 🍂 🌊