Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build date from the output of --version #25821

Merged
merged 1 commit into from
Jun 2, 2015
Merged

Remove build date from the output of --version #25821

merged 1 commit into from
Jun 2, 2015

Conversation

jooert
Copy link
Contributor

@jooert jooert commented May 27, 2015

Closes #25812.

@rust-highfive
Copy link
Collaborator

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@jooert
Copy link
Contributor Author

jooert commented May 27, 2015

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned pcwalton May 27, 2015
@brson
Copy link
Contributor

brson commented Jun 1, 2015

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 1, 2015

📌 Commit c408667 has been approved by brson

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 2, 2015
@Manishearth
Rollup merge of rust-lang#25821 - jooert:remove_build_date, r=brson
4f5a744 
Closes rust-lang#25812.
@Manishearth Manishearth mentioned this pull request Jun 2, 2015
Merged
bors added a commit that referenced this pull request Jun 2, 2015
@bors
Auto merge of #25958 - Manishearth:rollup, r=Manishearth
48e9ef6 
- Successful merges: #25751, #25821, #25920, #25932, #25933, #25936, #25941, #25949, #25951
- Failed merges:
@bors bors merged commit c408667 into rust-lang:master Jun 2, 2015
@jooert jooert deleted the remove_build_date branch June 2, 2015 11:38
@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 3, 2015
@brson
Copy link
Contributor

brson commented Jun 3, 2015

Nominating for beta because this breaks parsing of rustc --version so better to do it quickly.

@alexcrichton
Copy link
Member

cc @rust-lang/tools

I agree this should be backported

@alexcrichton
Copy link
Member

Accepting for the backport

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 10, 2015
@alexcrichton alexcrichton mentioned this pull request Jun 10, 2015
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove build date from --version
6 participants
@jooert @rust-highfive @brson @bors @alexcrichton @pcwalton