Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 213: Implement Default Type Parameter Fallback #26870

Merged
merged 18 commits into from
Jul 26, 2015
Merged

RFC 213: Implement Default Type Parameter Fallback #26870

merged 18 commits into from
Jul 26, 2015

Commits on Jul 26, 2015

  1. Implement Default TyParam fallback 

    This patch allows type parameter defaults to influence type inference. This is a possible breaking change since it effects the way type inference works and will have different behavior when mixing defaults and literal fallback.
    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    bbcb13d View commit details
    Browse the repository at this point in the history

  2. Fix tidy

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    91de8e6 View commit details
    Browse the repository at this point in the history

  3. Correctly collect defaults from type alises in astconv

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    bbdca2c View commit details
    Browse the repository at this point in the history

  4. Remove defaults table and attach defaults directly to tyvars

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    49eb2c6 View commit details
    Browse the repository at this point in the history

  5. Fix bug with defaults not being restored

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    d782e35 View commit details
    Browse the repository at this point in the history

  6. Refactor the default type parameter algorithm 

    The algorithm was not correctly detecting conflicts after moving
defaults into TypeVariableValue. The updated algorithm
correctly detects and reports conflicts with information about
where the conflict occured and which items the defaults were
introduced by. The span's for said items are not being correctly
attached and still need to be patched.
    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    01dcb3b View commit details
    Browse the repository at this point in the history

  7. Clean up test cases

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    e857871 View commit details
    Browse the repository at this point in the history

  8. Rebase fixes

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    ee43920 View commit details
    Browse the repository at this point in the history

  9. Remove second transaction

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    b75f215 View commit details
    Browse the repository at this point in the history

  10. Correctly subst defaults with the in-scope substs

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    fbfbdd7 View commit details
    Browse the repository at this point in the history

  11. Fix error message spans

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    ed3fbba View commit details
    Browse the repository at this point in the history

  12. Rework cross crate error messages

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    99a1293 View commit details
    Browse the repository at this point in the history

  13. Address tidy

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    7716541 View commit details
    Browse the repository at this point in the history

  14. Add cross-crate error message tests

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    d732f73 View commit details
    Browse the repository at this point in the history

  15. Make default error reporting deterministic

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    9da04b2 View commit details
    Browse the repository at this point in the history

  16. Add feature gate

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    55621b6 View commit details
    Browse the repository at this point in the history

  17. Address nit

    @jroesch
    jroesch authored and Jared Roesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    8ea9672 View commit details
    Browse the repository at this point in the history

  18. Add omitted trailing comma

    @jroesch
    jroesch committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    5ad36cb View commit details
    Browse the repository at this point in the history