std: Deprecate a number of unstable features #26914

alexcrichton · 2015-07-09T07:13:21Z

Many of these have long since reached their stage of being obsolete, so this
commit starts the removal process for all of them. The unstable features that
were deprecated are:

box_heap
cmp_partial
fs_time
hash_default
int_slice
iter_min_max
iter_reset_fuse
iter_to_vec
map_in_place
move_from
owned_ascii_ext
page_size
read_and_zero
scan_state
slice_chars
slice_position_elem
subslice_offset

rust-highfive · 2015-07-09T07:13:33Z

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2015-07-09T07:13:41Z

r? @aturon

cc @rust-lang/libs

bluss · 2015-07-09T08:30:42Z

src/libcore/iter.rs

@@ -2448,6 +2459,8 @@ impl<I> Fuse<I> {
    /// previously returned `None`.
    #[inline]
    #[unstable(feature = "iter_reset_fuse", reason = "seems marginal")]
+    #[deprecated(since = "1.3.0",
+                 reason = "unusual for adaptors to have one-off methods")]


This is an unusual comment :-) I don't disagree with the deprecation, but I'd like to add a method to fuse, to query its fused/nonfused state, it would be quite useful.

Yeah, I agree: the problem here isn't the one-off-ness per se, but rather that this method doesn't seem terribly useful in practice.

nagisa · 2015-07-10T17:35:47Z

src/libcore/cmp.rs

@@ -401,6 +401,7 @@ pub fn max<T: Ord>(v1: T, v2: T) -> T {
 /// ```
 #[inline]
 #[unstable(feature = "cmp_partial")]
+#[deprecated(since = "1.3.0", reason = "has not proven itself worthwhile")]


This only deprecates partial_min, but not partial_max. Are you sure that’s not an oversight?

Oops, thanks!

nagisa · 2015-07-10T17:42:07Z

I have no complaints about scope of this PR 😊

bors · 2015-07-24T12:34:11Z

☔ The latest upstream changes (presumably #27215) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2015-07-26T12:19:47Z

☔ The latest upstream changes (presumably #26870) made this pull request unmergeable. Please resolve the merge conflicts.

bluss · 2015-07-26T21:53:41Z

I'd like to keep position elem. We want this functionality in some form (I imagine something like .find<P>(p: P) where P: SlicePattern in the end, inspired by str's patterns). Can we rename it to .find(elem: &T) for now, and wait for an RFC and design to generalize its signature in the future?

aturon · 2015-07-27T15:17:34Z

src/liballoc/boxed.rs

@@ -86,10 +86,13 @@ use core::raw::{TraitObject};
 #[lang = "exchange_heap"]
 #[unstable(feature = "box_heap",
           reason = "may be renamed; uncertain about custom allocator design")]
+#[allow(deprecated)]


cc @pnkfelix -- can you comment on whether we may still want this constant with the upcoming box/allocator system?

aturon · 2015-07-27T22:52:52Z

r=me modulo nits.

alexcrichton · 2015-07-27T23:30:09Z

@bluss perhaps, yeah, but I'd prefer to keep the scope of this PR to just deprecate items instead of adding and/or renaming new APIs.

alexcrichton · 2015-07-27T23:30:32Z

@bors: r=aturon a1227e87c96c3e083467b8c5fb373b09c0f38e6c

bors · 2015-07-27T23:32:29Z

⌛ Testing commit a1227e8 with merge be324ca...

bors · 2015-07-27T23:38:03Z

💔 Test failed - auto-win-gnu-32-nopt-t

Many of these have long since reached their stage of being obsolete, so this commit starts the removal process for all of them. The unstable features that were deprecated are: * cmp_partial * fs_time * hash_default * int_slice * iter_min_max * iter_reset_fuse * iter_to_vec * map_in_place * move_from * owned_ascii_ext * page_size * read_and_zero * scan_state * slice_chars * slice_position_elem * subslice_offset

alexcrichton · 2015-07-27T23:40:01Z

@bors: r=aturon

On Mon, Jul 27, 2015 at 4:38 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-32-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-nopt-t/builds/842

—
Reply to this email directly or view it on GitHub
#26914 (comment).

bors · 2015-07-27T23:40:01Z

📌 Commit b3aa1a6 has been approved by aturon

bluss · 2015-07-27T23:48:36Z

src/libcollections/vec.rs

@@ -1627,6 +1630,7 @@ impl<T> IntoIter<T> {
    #[inline]
    /// Drops all items that have not yet been moved and returns the empty vector.
    #[unstable(feature = "iter_to_vec")]
+    #[deprecated(since = "1.3.0", reason = "replaced by drain()")]


I don't see how this is replaced by drain, it may in fact be very useful (I'd use it in itertools if it were stable).

Yes this isn't replaced by Drain -- in particular IntoIter allows you to return the Vec up and transport it around -- Drain doesn't. Still, this seems fairly marginal for today's std.

True, but I believe that this was originally added to get back the original allocation, in which case drain suffices for this.

Not for every use case, for example not for GroupByLazy, which would like to recycle allocations of the IntoIters it uses.

bluss · 2015-07-27T23:52:57Z

@alexcrichton You don't need to rename it, I just suggested not deprecating position_elem yet.

alexcrichton · 2015-07-28T00:59:56Z

Possibly, yeah, but it's slated to be deprecated soon anyway so it doesn't seem too bad to just go ahead and do so.

bors · 2015-07-28T01:12:40Z

⌛ Testing commit b3aa1a6 with merge 9ca511c...

Many of these have long since reached their stage of being obsolete, so this commit starts the removal process for all of them. The unstable features that were deprecated are: * box_heap * cmp_partial * fs_time * hash_default * int_slice * iter_min_max * iter_reset_fuse * iter_to_vec * map_in_place * move_from * owned_ascii_ext * page_size * read_and_zero * scan_state * slice_chars * slice_position_elem * subslice_offset

bors · 2015-07-28T03:31:56Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

cristicbz · 2015-08-17T11:53:22Z

src/libstd/env.rs

@@ -590,6 +590,8 @@ impl ExactSizeIterator for ArgsOs {

 /// Returns the page size of the current architecture in bytes.
 #[unstable(feature = "page_size", reason = "naming and/or location may change")]
+#[deprecated(since = "1.3.0",


This is used by coroutine-rs, would be nice to provide this somewhere since it's os specific and non-trivial to obtain.

rust-highfive assigned huonw Jul 9, 2015

alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 9, 2015

rust-highfive assigned aturon and unassigned huonw Jul 9, 2015

bluss reviewed Jul 9, 2015
View reviewed changes

alexcrichton force-pushed the deprecate-easy branch from d851cce to 136bc80 Compare July 10, 2015 16:43

nagisa reviewed Jul 10, 2015
View reviewed changes

alexcrichton force-pushed the deprecate-easy branch from 136bc80 to 012f993 Compare July 10, 2015 21:24

alexcrichton force-pushed the deprecate-easy branch from 012f993 to 19e9951 Compare July 24, 2015 16:11

Gankra added the I-needs-decision Issue: In need of a decision. label Jul 24, 2015

alexcrichton force-pushed the deprecate-easy branch from 19e9951 to ef225d4 Compare July 24, 2015 17:03

alexcrichton force-pushed the deprecate-easy branch 2 times, most recently from 53e662e to a1227e8 Compare July 26, 2015 17:19

aturon reviewed Jul 27, 2015
View reviewed changes

alexcrichton force-pushed the deprecate-easy branch from a1227e8 to b3aa1a6 Compare July 27, 2015 23:39

bluss reviewed Jul 27, 2015
View reviewed changes

bors merged commit b3aa1a6 into rust-lang:master Jul 28, 2015

SimonSapin mentioned this pull request Aug 2, 2015

Low hanging Dromaeo fruit servo/servo#6900

Closed

alexcrichton deleted the deprecate-easy branch August 4, 2015 15:52

SimonSapin mentioned this pull request Aug 4, 2015

Add ByNeed and Predicate traits #27517

Closed

cristicbz reviewed Aug 17, 2015
View reviewed changes

durka mentioned this pull request Aug 27, 2015

Anomalous unstable feature annotations #28037

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

std: Deprecate a number of unstable features #26914

std: Deprecate a number of unstable features #26914

alexcrichton commented Jul 9, 2015

rust-highfive commented Jul 9, 2015

alexcrichton commented Jul 9, 2015

bluss Jul 9, 2015

aturon Jul 27, 2015

nagisa Jul 10, 2015

alexcrichton Jul 10, 2015

nagisa commented Jul 10, 2015

bors commented Jul 24, 2015

bors commented Jul 26, 2015

bluss commented Jul 26, 2015

aturon Jul 27, 2015

aturon commented Jul 27, 2015

alexcrichton commented Jul 27, 2015

alexcrichton commented Jul 27, 2015

bors commented Jul 27, 2015

bors commented Jul 27, 2015

alexcrichton commented Jul 27, 2015

bors commented Jul 27, 2015

bluss Jul 27, 2015

Gankra Jul 27, 2015

alexcrichton Jul 28, 2015

bluss Jul 29, 2015

bluss commented Jul 27, 2015

alexcrichton commented Jul 28, 2015

bors commented Jul 28, 2015

bors commented Jul 28, 2015

cristicbz Aug 17, 2015

std: Deprecate a number of unstable features #26914

std: Deprecate a number of unstable features #26914

Conversation

alexcrichton commented Jul 9, 2015

rust-highfive commented Jul 9, 2015

alexcrichton commented Jul 9, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nagisa commented Jul 10, 2015

bors commented Jul 24, 2015

bors commented Jul 26, 2015

bluss commented Jul 26, 2015

Choose a reason for hiding this comment

aturon commented Jul 27, 2015

alexcrichton commented Jul 27, 2015

alexcrichton commented Jul 27, 2015

bors commented Jul 27, 2015

bors commented Jul 27, 2015

alexcrichton commented Jul 27, 2015

bors commented Jul 27, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bluss commented Jul 27, 2015

alexcrichton commented Jul 28, 2015

bors commented Jul 28, 2015

bors commented Jul 28, 2015

Choose a reason for hiding this comment