Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gate associated type defaults #27382

Merged
merged 3 commits into from
Jul 31, 2015
Merged

Gate associated type defaults #27382

merged 3 commits into from
Jul 31, 2015

Conversation

brson
Copy link
Contributor

@brson brson commented Jul 29, 2015

There are still problems in both the design and implementation of this, so we don't want it landing in 1.2.

cc @arielb1 @nikomatsakis

cc #27364

r? @alexcrichton

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 29, 2015
@brson
Copy link
Contributor Author

brson commented Jul 29, 2015

Hm, this doesn't actually work locally. Still testing.

@brson
Copy link
Contributor Author

brson commented Jul 29, 2015

OK, this is ready to go. I'd like to get this backported and I'll crater test on the beta branch.

@brson
Copy link
Contributor Author

brson commented Jul 29, 2015

r? @alexcrichton

@brson brson mentioned this pull request Jul 29, 2015
Merged
@brson
Copy link
Contributor Author

brson commented Jul 29, 2015

Running through crater.

@brson
Feature gate associated type defaults
a09bce1 
There are multiple issues with them as designed and implemented.

cc rust-lang#27364
@brson
Copy link
Contributor Author

brson commented Jul 30, 2015

4 regressions. No non-root regressions.

@brson
Copy link
Contributor Author

brson commented Jul 30, 2015

Those regressions are either for non-stable-compatible crates or those crates are not using the defaults.

@brson brson added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. relnotes Marks issues that should be documented in the release notes of the next release. beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jul 30, 2015
@brson
Copy link
Contributor Author

brson commented Jul 30, 2015

@aturon is satisfied with this breakage. @bors r+

@bors
Copy link
Contributor

bors commented Jul 30, 2015

📌 Commit a09bce1 has been approved by brson

@brson brson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 30, 2015
@brson
Copy link
Contributor Author

brson commented Jul 30, 2015

@bors r=aturon

@bors
Copy link
Contributor

bors commented Jul 30, 2015

📌 Commit a09bce1 has been approved by brson

@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 30, 2015
@bors
Copy link
Contributor

bors commented Jul 30, 2015

⌛ Testing commit a09bce1 with merge d5fc0da...

@bors
Copy link
Contributor

bors commented Jul 30, 2015

💔 Test failed - auto-mac-64-opt

@brson
Copy link
Contributor Author

brson commented Jul 30, 2015

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 30, 2015

📌 Commit 4aaf1be has been approved by alexcrichton

bors added a commit that referenced this pull request Jul 31, 2015
@bors
Auto merge of #27382 - brson:gate-assoc-type, r=alexcrichton
8d2eb59 
There are still problems in both the design and implementation of this, so we don't want it landing in 1.2.

cc @arielb1 @nikomatsakis 

cc #27364

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jul 31, 2015

⌛ Testing commit 4aaf1be with merge 8d2eb59...

@bors
Copy link
Contributor

bors commented Jul 31, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 4aaf1be into rust-lang:master Jul 31, 2015
This was referenced Jul 31, 2015
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brson @bors @alexcrichton