Ignore PhantomData when checking CoerceUnsized implementations #27483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Otherwise, simply copy the data from the source. | ||
| assert_eq!(src_ty, target_ty); | ||
| if !is_phantom { | ||
| assert_eq!(src_ty, target_ty); |
There was a problem hiding this comment.
assert!(is_phantom || src_ty == target_ty);
Gankra
force-pushed
the
aint-fraid-a-no-ghosts
branch
from
5265376 to
d1f94b7
Compare
|
r=me with an extra test and nits addressed, should wait for the RFC before landing though |
Gankra
force-pushed
the
aint-fraid-a-no-ghosts
branch
from
d1f94b7 to
ff01a42
Compare
Gankra
force-pushed
the
aint-fraid-a-no-ghosts
branch
from
ff01a42 to
2214483
Compare
|
nits addressed, I think. |
|
Thanks! r=me, but waiting on RFC |
|
LGTM. You could deduplicate the check by adding an |
|
☔ The latest upstream changes (presumably #27551) made this pull request unmergeable. Please resolve the merge conflicts. |
This was referenced Sep 12, 2015
|
superseded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26905
May want to wait on rust-lang/rfcs#1234
I'm not super happy with the duplicated logic in trans and typeck, and would love to know if there's a "better way". It's pretty minimal, regardless.
r? @nrc