adding base64 and to_bytes to stdlib #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The general "rich library" discussion seems to take place in #2729 |
|
I agree with both of these. Although putting features into core that don't have an immediate use worries me a little, to_bytes does make sense in light of to_str. |
brson
added a commit
that referenced
this pull request
Jul 4, 2012
adding base64 and to_bytes to stdlib
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Feb 26, 2023
Get Miri working on ARM - Add a shim for `llvm.arm.hint`, which is required by `core::hint::spin_loop` on `arm` targets. The shim simply calls `yield_active_thread` on a YIELD hint, just like the shim for `llvm.aarch64.isb` that's already present. - Change the signature of `miri_host_to_target_path` to use `c_char` instead of `i8`, to make it compatible with `CStr` on targets where `c_char` is unsigned. The implementation of `miri_host_to_target_path` accesses the memory as bytes and does not need to be adjusted. - Enable ARM targets in CI. Specifically, `aarch64-unknown-linux-gnu` and `arm-unknown-linux-gnueabi` on the Linux host. Since all tests also pass for `aarch64-unknown-linux-gnu` I took the liberty of adding that target to CI as well. Fixes rust-lang#2791
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Next Kani release. Also includes fixes to changelog formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good evening,
@graydon mentioned a while ago that base64 encoding/decoding would be a good candidate for the standard library. I also included a
to_bytesiface as well, which parallels theto_striface. Are these still appropriate? Or do you all think it'd be better to put this in a cargo crate?