Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Convert negate_unsigned feature gate to a warning" #28468

Merged
merged 1 commit into from
Sep 19, 2015
Merged

Revert "Convert negate_unsigned feature gate to a warning" #28468

merged 1 commit into from
Sep 19, 2015

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Sep 17, 2015

This reverts commit 0ca8e49.

Fixes #27141

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@nagisa nagisa force-pushed the revert-negate-unsigned-warning branch from df3d3ab to 240d018 Compare September 18, 2015 13:04
@alexcrichton
Copy link
Member

Looks like there's a legit test failure on travis, but otherwise r=me.

@nagisa nagisa force-pushed the revert-negate-unsigned-warning branch from 240d018 to 8131c63 Compare September 18, 2015 16:34
@nagisa
Copy link
Member Author

nagisa commented Sep 18, 2015

I believe I fixed it.

@alexcrichton
Copy link
Member

Could you squash the commits together as well?

@nagisa
Revert "Convert negate_unsigned feature gate to a warning"
5104a93 
This reverts commit 0ca8e49 and fixes the code to work with
current rustc.

Fixes rust-lang#27141
@nagisa nagisa force-pushed the revert-negate-unsigned-warning branch from 8131c63 to 5104a93 Compare September 18, 2015 17:22
@nagisa
Copy link
Member Author

nagisa commented Sep 18, 2015

Done.

@alexcrichton
Copy link
Member

@bors: r+ 5104a93

@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 18, 2015
@alexcrichton
Copy link
Member

Tagging with relnotes for @brson as well

@bors
Copy link
Contributor

bors commented Sep 18, 2015

⌛ Testing commit 5104a93 with merge bd9f031...

bors added a commit that referenced this pull request Sep 18, 2015
@bors
Auto merge of #28468 - nagisa:revert-negate-unsigned-warning, r=alexc…
bd9f031 
…richton

This reverts commit 0ca8e49.

Fixes #27141
@bors
Copy link
Contributor

bors commented Sep 19, 2015

💔 Test failed - auto-win-gnu-32-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Sep 18, 2015 at 5:08 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-32-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-nopt-t/builds/1458

—
Reply to this email directly or view it on GitHub
#28468 (comment).

@bors
Copy link
Contributor

bors commented Sep 19, 2015

⌛ Testing commit 5104a93 with merge 2915f89...

bors added a commit that referenced this pull request Sep 19, 2015
@bors
Auto merge of #28468 - nagisa:revert-negate-unsigned-warning, r=alexc…
2915f89 
…richton

This reverts commit 0ca8e49.

Fixes #27141
@bors
Copy link
Contributor

bors commented Sep 19, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 5104a93 into rust-lang:master Sep 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nagisa @rust-highfive @alexcrichton @bors @brson