Always pass /DEBUG flag to MSVC linker
#28505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is pending discussion on the referenced issue. |
|
I'm ok with this as it seems the only downside is an extra file is generated, but that already happens for dylibs and it's not necessarily harming anyone either! I'm also not too too worried about having a switch to not pass this flag as it doesn't seem too crucial. Thoughts @brson? |
|
Still waiting for some more discussion. |
|
With the dsymutil precedent I'm mildly ok with having pdbs just silently emitted. |
bors
added a commit
that referenced
this pull request
Sep 25, 2015
|
Looks like @bors is stuck? |
|
It looks like the android bot didn't start for whatever reason. |
matklad
added a commit
to matklad/cargo
that referenced
this pull request
Mar 14, 2018
Depending on the OS, there might be an additional artifacts for debuginfo (dSYM folder for macs, .pbd file for windows). Given that we can't disable `.pdb` for windows[1], let's just ignore all filenames! [1]: rust-lang/rust#28505)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28448.
r? @brson