-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaned up trans/consts #30110
cleaned up trans/consts #30110
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
14dcaf5
to
0b1be7d
Compare
☔ The latest upstream changes (presumably #29929) made this pull request unmergeable. Please resolve the merge conflicts. |
0b1be7d
to
ab51261
Compare
rebased |
☔ The latest upstream changes (presumably #25570) made this pull request unmergeable. Please resolve the merge conflicts. |
ab51261
to
b2c3a5d
Compare
rebased |
☔ The latest upstream changes (presumably #30084) made this pull request unmergeable. Please resolve the merge conflicts. |
b2c3a5d
to
b853115
Compare
rebased and simplified this PR to only change some matches into |
⌛ Testing commit b853115 with merge c98d5e7... |
💔 Test failed - auto-mac-64-opt |
spurious git failure |
@bors: retry On Fri, Dec 11, 2015 at 3:10 AM, Oliver Schneider notifications@github.com
|
⌛ Testing commit b853115 with merge 97c4863... |
💔 Test failed - auto-mac-64-opt |
@bors: retry On Fri, Dec 11, 2015 at 11:54 PM, bors notifications@github.com wrote:
|
turned some `match`es into `if let`s.
turned some
match
es intoif let
s.