Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up trans/consts #30110

Merged
merged 1 commit into from
Dec 12, 2015
Merged

cleaned up trans/consts #30110

merged 1 commit into from
Dec 12, 2015

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 30, 2015

turned some matches into if lets.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors
Copy link
Contributor

bors commented Nov 30, 2015

☔ The latest upstream changes (presumably #29929) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the pretty_const_trans branch from 0b1be7d to ab51261 Compare December 1, 2015 09:08
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 1, 2015

rebased

@bors
Copy link
Contributor

bors commented Dec 1, 2015

☔ The latest upstream changes (presumably #25570) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the pretty_const_trans branch from ab51261 to b2c3a5d Compare December 2, 2015 09:39
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 2, 2015

rebased

@bors
Copy link
Contributor

bors commented Dec 4, 2015

☔ The latest upstream changes (presumably #30084) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the pretty_const_trans branch from b2c3a5d to b853115 Compare December 8, 2015 15:07
@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 8, 2015

rebased and simplified this PR to only change some matches into if let. The other changes will be in their own PRs.

@oli-obk oli-obk changed the title cleaned up const_eval and trans/consts cleaned up trans/consts Dec 8, 2015
@pnkfelix
Copy link
Member

@bors r+ b853115 rollup

@bors
Copy link
Contributor

bors commented Dec 11, 2015

⌛ Testing commit b853115 with merge c98d5e7...

@bors
Copy link
Contributor

bors commented Dec 11, 2015

💔 Test failed - auto-mac-64-opt

@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 11, 2015

spurious git failure

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Dec 11, 2015 at 3:10 AM, Oliver Schneider notifications@github.com
wrote:

spurious git failure in travis


Reply to this email directly or view it on GitHub
#30110 (comment).

@bors
Copy link
Contributor

bors commented Dec 12, 2015

⌛ Testing commit b853115 with merge 97c4863...

@bors
Copy link
Contributor

bors commented Dec 12, 2015

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Dec 11, 2015 at 11:54 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/7365


Reply to this email directly or view it on GitHub
#30110 (comment).

bors added a commit that referenced this pull request Dec 12, 2015
turned some `match`es into `if let`s.
@bors
Copy link
Contributor

bors commented Dec 12, 2015

⌛ Testing commit b853115 with merge 45a73c8...

@bors bors merged commit b853115 into rust-lang:master Dec 12, 2015
@oli-obk oli-obk deleted the pretty_const_trans branch December 12, 2015 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants