configure: fix compatibility issue with Apple clang 4.0 #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compatibility with Mountain Lion. Closes #3049.
|
Silly question: you're able to build and run |
|
I wonder why Apple calls their clang 4.0. |
|
Yes, the following commands work nicely on Mountain Lion: There are no test failures. |
|
Great. I'm going to go ahead and merge this into master as it seems very unlikely to cause problems, but if you submit any pull requests in the future that are more involved than this, please rebase them off the incoming branch - https://github.com/mozilla/rust/wiki/Note-git-workflow explains how.Thanks! |
|
Ops, I didn't know that. Thank you for the tip and sorry about the mess. |
|
No problem! |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
…braces-newline Trait Implementation - Adds a newline before the last brace on impls without a body if the first brace is also on a newline
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 3, 2023
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Oct 27, 2023
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Update the s2n-quic submodule to the latest commit. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix compatibility with Mountain Lion's clang.
Closes #3049.