Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some operator fixes for the syntax index #30545

Merged
merged 1 commit into from
Dec 25, 2015

Conversation

bluss
Copy link
Member

@bluss bluss commented Dec 23, 2015

book: Some operator fixes for the syntax index

  • Correct the names of the comparison traits (PartialOrd)
  • Mention only the traits that overload the operator (PartialOrd,
    PartialEq), not operator-unrelated traits (Ord, Eq).
  • Add != operator.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@bluss
Copy link
Member Author

bluss commented Dec 23, 2015

r? @steveklabnik

Does it need to say that the OpAssign things are unstable? :/

@steveklabnik
Copy link
Member

Does it need to say that the OpAssign things are unstable? :/

They should not exist here until they become stable. Outside of the NIghtly Rust stuff, only stable exists. 😉

- Correct the names of the comparison traits (PartialOrd)
- Mention only the traits that overload the operator (PartialOrd,
  PartialEq), not operator-unrelated traits (Ord, Eq).
- Add `!=` operator.
@bluss bluss force-pushed the operator-overload branch from 7a088e3 to 1b43831 Compare December 23, 2015 23:41
@bluss bluss changed the title book: Update operators and operator traits in the syntax index Some operator fixes for the syntax index Dec 23, 2015
@bluss
Copy link
Member Author

bluss commented Dec 23, 2015

😞 Ok, they'll live in ignorance of the glorious stuff that exists. Updated PR & description, now it's just the fixes.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Dec 24, 2015

📌 Commit 1b43831 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Dec 25, 2015
…bnik

book: Some operator fixes for the syntax index

- Correct the names of the comparison traits (PartialOrd)
- Mention only the traits that overload the operator (PartialOrd,
  PartialEq), not operator-unrelated traits (Ord, Eq).
- Add `!=` operator.
bors added a commit that referenced this pull request Dec 25, 2015
@bors bors merged commit 1b43831 into rust-lang:master Dec 25, 2015
@bluss bluss deleted the operator-overload branch December 26, 2015 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants