Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilise f32::to_{degrees,radians} to match f64 #30672

Merged
merged 1 commit into from
Jan 2, 2016
Merged

Stabilise f32::to_{degrees,radians} to match f64 #30672

merged 1 commit into from
Jan 2, 2016

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Jan 1, 2016

f64 methods have been stable since rust 1.0, but f32 never got stabilised.

I suggest backporting this to beta as well (needs changing stablilisation version then).

r? @aturon

Fixes rust-lang/rfcs#1438

@nagisa
Stabilise f32::to_{degrees,radians} to match f64
c921abf 
f64 methods have been stable since rust 1.0, but f32 never got stabilised.
@sfackler
Copy link
Member

sfackler commented Jan 1, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Jan 1, 2016

📌 Commit c921abf has been approved by sfackler

@bors
Copy link
Contributor

bors commented Jan 1, 2016

⌛ Testing commit c921abf with merge d4b67cd...

bors added a commit that referenced this pull request Jan 1, 2016
@bors
Auto merge of #30672 - nagisa:to-degrad-stab, r=sfackler
d4b67cd 
f64 methods have been stable since rust 1.0, but f32 never got stabilised.

I suggest backporting this to beta as well (needs changing stablilisation version then).

r? @aturon

Fixes rust-lang/rfcs#1438
@bors
Copy link
Contributor

bors commented Jan 2, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit c921abf into rust-lang:master Jan 2, 2016
@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 7, 2016
@brson
Copy link
Contributor

brson commented Jan 7, 2016

@nagisa suggested a backport

@aturon
Copy link
Member

aturon commented Jan 7, 2016

@brson I don't think that's necessary, but it's also pretty harmless. Up to you.

@brson brson added I-nominated T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. I-nominated labels Jan 7, 2016
@brson
Copy link
Contributor

brson commented Jan 12, 2016

Not backporting.

@cuviper cuviper mentioned this pull request Jul 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nagisa @sfackler @bors @brson @aturon