Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be a bit more correct about segfault causality #30821

Merged
merged 1 commit into from
Jan 14, 2016

Conversation

steveklabnik
Copy link
Member

Fixes #30819

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor

This is actually incorrect. The cause is certainly related to a violation of some invariant that the unsafe author expected to hold, but that violation itself can occur outside of an unsafe block. @RalfJung recently wrote about exactly this in a blog post, actually: https://www.ralfj.de/blog/2016/01/09/the-scope-of-unsafe.html Perhaps just rephrasing to "you can be sure the cause is related to one of the unsafe blocks" would be good?

@steveklabnik
Copy link
Member Author

Ugh, right. Thanks. Updating now with your wording.

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 11, 2016

📌 Commit eb2343f has been approved by nikomatsakis

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 14, 2016
bors added a commit that referenced this pull request Jan 14, 2016
@bors bors merged commit eb2343f into rust-lang:master Jan 14, 2016
@steveklabnik steveklabnik deleted the gh30819 branch June 19, 2016 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants