clean up trans_static_method_callee and friends #31072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
force-pushed
the
method-callee-cleanup
branch
from
981afa7 to
29c296f
Compare
|
I'll take a look at it ASAP. |
| let mthsubsts = tcx.mk_substs(mth.substs); | ||
| self.trans_fn_ref(bcx, ty, mthsubsts, mth.method.def_id) | ||
| let mth_substs = tcx.mk_substs(mth.substs); | ||
| self.trans_fn_ref(bcx, ty, mth_substs, mth.method.def_id) |
|
Very nice work! Much cleaner indeed. Is there a specific reason you don't erase regions in some of the cases anymore? It probably doesn't matter most of the time, since the consumer of the r=me when you have taken care of that empty |
|
fixed that |
|
We don't need to erase regions again because |
|
@bors r=michaelwoerister |
|
📌 Commit 0a01d0b has been approved by |
bors
added a commit
that referenced
this pull request
Jan 22, 2016
The old code was terribly ugly and was duplicated in several places. r? @michaelwoerister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code was terribly ugly and was duplicated in several places.
r? @michaelwoerister