mk: Move from `-D warnings` to `#![deny(warnings)]` #31120

alexcrichton · 2016-01-22T17:47:54Z

This commit removes the -D warnings flag being passed through the makefiles to
all crates to instead be a crate attribute. We want these attributes always
applied for all our standard builds, and this is more amenable to Cargo-based
builds as well.

Note that all deny(warnings) attributes are gated with a cfg(stage0)
attribute currently to match the same semantics we have today

rust-highfive · 2016-01-22T17:48:05Z

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2016-01-22T17:49:15Z

One change I also noticed was that the rustc_mir crate did not previously have an #[unstable] tag, which means that this compiles in stable Rust:

extern crate rustc_mir;

fn main() {}

I added the #[unstable] tag here, but I would be quite surprised if that actually caused breakage. @brson do you think it's worth adding to relnotes?

brson · 2016-01-22T18:15:44Z

@alexcrichton It may not be worth mentioning but I'll tag it and think about it later. Also nominating for beta, maybe just the rustc_mir crate fix.

Here's an issue to lint for this problem: #31122

alexcrichton · 2016-01-22T18:16:37Z

Oh let me rearrange the commits for the new unstable attribute to be in its own commit to be easily cherry-picked in that case.

alexcrichton · 2016-01-22T18:17:52Z

rearranged

brson · 2016-01-22T18:20:18Z

@bors r+

bors · 2016-01-22T18:20:19Z

📌 Commit 3a107c5 has been approved by brson

bors · 2016-01-23T02:23:48Z

⌛ Testing commit 3a107c5 with merge 234e3dd...

bors · 2016-01-23T03:11:33Z

💔 Test failed - auto-mac-64-opt

alexcrichton · 2016-01-23T07:51:39Z

@bors: r=brson ae8f816

bors · 2016-01-23T09:34:07Z

⌛ Testing commit ae8f816 with merge 96b734f...

bors · 2016-01-23T09:49:33Z

💔 Test failed - auto-linux-64-x-android-t

bors · 2016-01-23T18:22:01Z

☔ The latest upstream changes (presumably #31148) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2016-01-24T18:43:35Z

@bors: r=brson fc8d780

bors · 2016-01-24T19:58:15Z

⌛ Testing commit fc8d780 with merge 5ead8cf...

bors · 2016-01-24T20:13:13Z

💔 Test failed - auto-linux-64-x-android-t

This commit removes the `-D warnings` flag being passed through the makefiles to all crates to instead be a crate attribute. We want these attributes always applied for all our standard builds, and this is more amenable to Cargo-based builds as well. Note that all `deny(warnings)` attributes are gated with a `cfg(stage0)` attribute currently to match the same semantics we have today

Wouldn't want to be able to link to this on stable Rust!

alexcrichton · 2016-01-25T04:37:21Z

@bors: r=brson cc4db8b

alexcrichton · 2016-01-25T17:12:40Z

@bors: r=brson 790b862

tamird · 2016-01-25T22:10:17Z

travis failed btw

src/libstd/process.rs:849:5: 866:6 error: duplicate definition of value `test_inherit_env` [E0428]
src/libstd/process.rs:849     fn test_inherit_env() {
src/libstd/process.rs:850         use env;
src/libstd/process.rs:851 
src/libstd/process.rs:852         let mut result = env_cmd().output().unwrap();
src/libstd/process.rs:853         let output = String::from_utf8(result.stdout).unwrap();
src/libstd/process.rs:854 
                          ...
src/libstd/process.rs:849:5: 866:6 help: run `rustc --explain E0428` to see a detailed explanation
src/libstd/process.rs:829:5: 845:6 note: first definition of value `test_inherit_env` here
src/libstd/process.rs:829     fn test_inherit_env() {
src/libstd/process.rs:830         use env;
src/libstd/process.rs:831 
src/libstd/process.rs:832         let result = env_cmd().output().unwrap();
src/libstd/process.rs:833         let output = String::from_utf8(result.stdout).unwrap();
src/libstd/process.rs:834

tamird · 2016-01-25T22:13:15Z

src/libstd/process.rs

    #[test]
+    #[cfg_attr(target_os = "android", ignore)]


shouldn't this not be ignored on android?

alexcrichton · 2016-01-26T00:57:31Z

@bors: r=brson 9d95a22

bors · 2016-01-26T04:19:28Z

⌛ Testing commit 9d95a22 with merge 2518a71...

bors · 2016-01-26T06:03:06Z

💔 Test failed - auto-win-msvc-64-opt

alexcrichton · 2016-01-26T16:29:28Z

@bors: r=brson cdc1c2c

bors · 2016-01-26T16:29:32Z

⌛ Testing commit cdc1c2c with merge 669130e...

bors · 2016-01-26T16:50:26Z

💔 Test failed - auto-mac-64-nopt-t

The deny(warnings) attribute is now enabled for tests so we need to weed out these warnings as well.

alexcrichton · 2016-01-26T17:29:52Z

@bors: r=brson cb343c3

This commit removes the `-D warnings` flag being passed through the makefiles to all crates to instead be a crate attribute. We want these attributes always applied for all our standard builds, and this is more amenable to Cargo-based builds as well. Note that all `deny(warnings)` attributes are gated with a `cfg(stage0)` attribute currently to match the same semantics we have today

bors · 2016-01-26T22:10:11Z

⌛ Testing commit cb343c3 with merge 4b61585...

bors · 2016-01-27T00:25:46Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

alexcrichton · 2016-01-27T17:05:13Z

flagging as beta-accepted, but only the commit alexcrichton@4b3c355

rust-highfive assigned brson Jan 22, 2016

brson added relnotes Marks issues that should be documented in the release notes of the next release. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jan 22, 2016

brson mentioned this pull request Jan 22, 2016

Add lint that all crates are #[unstable] #31122

Closed

alexcrichton force-pushed the attribute-deny-warnings branch from 85ab967 to 3a107c5 Compare January 22, 2016 18:17

alexcrichton force-pushed the attribute-deny-warnings branch from 3a107c5 to ae8f816 Compare January 23, 2016 07:51

alexcrichton force-pushed the attribute-deny-warnings branch from ae8f816 to fc8d780 Compare January 24, 2016 18:43

alexcrichton added 2 commits January 24, 2016 20:35

rustc_mir: Mark the crate as unstable

4b3c355

Wouldn't want to be able to link to this on stable Rust!

alexcrichton force-pushed the attribute-deny-warnings branch from fc8d780 to cc4db8b Compare January 25, 2016 04:37

tamird reviewed Jan 25, 2016
View reviewed changes

src/libstd/process.rs

#[test]

#[cfg_attr(target_os = "android", ignore)]

Copy link

Contributor

tamird Jan 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this not be ignored on android?

alexcrichton force-pushed the attribute-deny-warnings branch from 790b862 to 9d95a22 Compare January 26, 2016 00:57

alexcrichton force-pushed the attribute-deny-warnings branch from 9d95a22 to cdc1c2c Compare January 26, 2016 16:29

Fix warnings during tests

cb343c3

The deny(warnings) attribute is now enabled for tests so we need to weed out these warnings as well.

alexcrichton force-pushed the attribute-deny-warnings branch from cdc1c2c to cb343c3 Compare January 26, 2016 17:29

bors merged commit cb343c3 into rust-lang:master Jan 27, 2016

alexcrichton deleted the attribute-deny-warnings branch January 27, 2016 00:27

alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 27, 2016

alexcrichton mentioned this pull request Feb 3, 2016

Merge in beta-accepted into beta #31392

Merged

alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 10, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mk: Move from `-D warnings` to `#![deny(warnings)]` #31120

mk: Move from `-D warnings` to `#![deny(warnings)]` #31120

alexcrichton commented Jan 22, 2016

rust-highfive commented Jan 22, 2016

alexcrichton commented Jan 22, 2016

brson commented Jan 22, 2016

alexcrichton commented Jan 22, 2016

alexcrichton commented Jan 22, 2016

brson commented Jan 22, 2016

bors commented Jan 22, 2016

bors commented Jan 23, 2016

bors commented Jan 23, 2016

alexcrichton commented Jan 23, 2016

bors commented Jan 23, 2016

bors commented Jan 23, 2016

bors commented Jan 23, 2016

alexcrichton commented Jan 24, 2016

bors commented Jan 24, 2016

bors commented Jan 24, 2016

alexcrichton commented Jan 25, 2016

alexcrichton commented Jan 25, 2016

tamird commented Jan 25, 2016

tamird Jan 25, 2016

alexcrichton commented Jan 26, 2016

bors commented Jan 26, 2016

bors commented Jan 26, 2016

alexcrichton commented Jan 26, 2016

bors commented Jan 26, 2016

bors commented Jan 26, 2016

alexcrichton commented Jan 26, 2016

bors commented Jan 26, 2016

bors commented Jan 27, 2016

alexcrichton commented Jan 27, 2016

mk: Move from -D warnings to #![deny(warnings)] #31120

mk: Move from -D warnings to #![deny(warnings)] #31120

Conversation

alexcrichton commented Jan 22, 2016

rust-highfive commented Jan 22, 2016

alexcrichton commented Jan 22, 2016

brson commented Jan 22, 2016

alexcrichton commented Jan 22, 2016

alexcrichton commented Jan 22, 2016

brson commented Jan 22, 2016

bors commented Jan 22, 2016

bors commented Jan 23, 2016

bors commented Jan 23, 2016

alexcrichton commented Jan 23, 2016

bors commented Jan 23, 2016

bors commented Jan 23, 2016

bors commented Jan 23, 2016

alexcrichton commented Jan 24, 2016

bors commented Jan 24, 2016

bors commented Jan 24, 2016

alexcrichton commented Jan 25, 2016

alexcrichton commented Jan 25, 2016

tamird commented Jan 25, 2016

tamird Jan 25, 2016

Choose a reason for hiding this comment

alexcrichton commented Jan 26, 2016

bors commented Jan 26, 2016

bors commented Jan 26, 2016

alexcrichton commented Jan 26, 2016

bors commented Jan 26, 2016

bors commented Jan 26, 2016

alexcrichton commented Jan 26, 2016

bors commented Jan 26, 2016

bors commented Jan 27, 2016

alexcrichton commented Jan 27, 2016

mk: Move from `-D warnings` to `#![deny(warnings)]` #31120

mk: Move from `-D warnings` to `#![deny(warnings)]` #31120