Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow registering MIR-passes through compiler plugins #31425

Merged
merged 3 commits into from
Feb 9, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Feb 5, 2016

depends on #31324

r? @nagisa

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nagisa
Copy link
Member

nagisa commented Feb 5, 2016

This looks okay to me.

EDIT: r=me once the dependency lands/is r+d.

@bors
Copy link
Contributor

bors commented Feb 6, 2016

☔ The latest upstream changes (presumably #31307) made this pull request unmergeable. Please resolve the merge conflicts.

@nagisa
Copy link
Member

nagisa commented Feb 9, 2016

Rebase?

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 9, 2016

done

@nagisa
Copy link
Member

nagisa commented Feb 9, 2016

@bors r+ 4b06718

@bors
Copy link
Contributor

bors commented Feb 9, 2016

⌛ Testing commit 4b06718 with merge 3ea4605...

@bors
Copy link
Contributor

bors commented Feb 9, 2016

💔 Test failed - auto-linux-64-opt

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 9, 2016

no clue where that error came from:

error: error pattern ' build without -C codegen-units for more exact errors' not found!
status: exit code: 101
command: x86_64-unknown-linux-gnu/stage2/bin/rustc /buildslave/rust-buildbot/slave/auto-linux-64-opt/build/src/test/compile-fail/asm-src-loc-codegen-units.rs -L x86_64-unknown-linux-gnu/test/compile-fail/ --target=x86_64-unknown-linux-gnu -L x86_64-unknown-linux-gnu/test/compile-fail/asm-src-loc-codegen-units.stage2-x86_64-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic -o x86_64-unknown-linux-gnu/test/compile-fail/asm-src-loc-codegen-units.stage2-x86_64-unknown-linux-gnu --cfg rtopt -C rpath -O -L x86_64-unknown-linux-gnu/rt -C codegen-units=2
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
thread 'error: codegen-1<inline asm>:1:2: error: invalid instruction mnemonic 'nowayisthisavalidinstruction'
        nowayisthisavalidinstruction
        ^
' panicked at 'Box<Any>', 
../src/libsyntax/errors/mod.rs:note607: 
build without -C codegen-units for more exact errorsnote: Run with `RUST_BACKTRACE=1` for a backtrace.

error: aborting due to previous error
error: aborting due to worker thread panic

------------------------------------------

thread '[compile-fail] compile-fail/asm-src-loc-codegen-units.rs' panicked at 'explicit panic', /buildslave/rust-buildbot/slave/auto-linux-64-opt/build/src/compiletest/runtest.rs:1527
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    [compile-fail] compile-fail/asm-src-loc-codegen-units.rs

@nagisa
Copy link
Member

nagisa commented Feb 9, 2016

@bors retry

Seems spurious to me: the error message is 2 different error messages interleaved which makes the actual error we’re looking for invalid.

@arielb1
Copy link
Contributor

arielb1 commented Feb 9, 2016

@bors retry

@bors
Copy link
Contributor

bors commented Feb 9, 2016

⌛ Testing commit 4b06718 with merge 096dbf8...

bors added a commit that referenced this pull request Feb 9, 2016
@bors bors merged commit 4b06718 into rust-lang:master Feb 9, 2016
@nrc
Copy link
Member

nrc commented Feb 10, 2016

What is the motivation for this? It would be nice if changes like this could get some discussion - an internals thread, or even an issue being opened beforehand. I feel we have been burnt by llvm plugin passes and don't want to repeat that experience. At the very least this facility should be documented.

@oli-obk oli-obk deleted the mir-pass-plugin branch February 10, 2016 06:41
@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants