-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow registering MIR-passes through compiler plugins #31425
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This looks okay to me. EDIT: r=me once the dependency lands/is r+d. |
☔ The latest upstream changes (presumably #31307) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebase? |
239a313
to
4b06718
Compare
done |
⌛ Testing commit 4b06718 with merge 3ea4605... |
💔 Test failed - auto-linux-64-opt |
no clue where that error came from:
|
@bors retry Seems spurious to me: the error message is 2 different error messages interleaved which makes the actual error we’re looking for invalid. |
@bors retry |
What is the motivation for this? It would be nice if changes like this could get some discussion - an internals thread, or even an issue being opened beforehand. I feel we have been burnt by llvm plugin passes and don't want to repeat that experience. At the very least this facility should be documented. |
Sorry about that. Discussion start: https://internals.rust-lang.org/t/mir-compiler-plugins-for-custom-mir-passes/3166 |
depends on #31324
r? @nagisa