Recover from missing brackets in the parser #31555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I'm probably the wrong one to review this, but perhaps r? @pnkfelix (or anyone else who feels ambitious) |
|
@nrc r=me once you fix the comment |
|
☔ The latest upstream changes (presumably #31487) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors: r=pnkfelix |
|
📌 Commit 1a91fbc has been approved by |
|
☔ The latest upstream changes (presumably #31583) made this pull request unmergeable. Please resolve the merge conflicts. |
Some tests just add the extra errors, others I fix by doing some simple error recovery. I've tried to avoid doing too much in the hope of doing something more principled later. In general error messages are getting worse at this stage, but I think in the long run they will get better.
|
@bors: r=pnkfelix |
|
📌 Commit 4e1a6f6 has been approved by |
|
@bors: r=pnkfelix |
|
📌 Commit 73a8513 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 15, 2016
Recover from missing brackets in the parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recover from missing brackets in the parser