Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ClosureKind variants and stop re-exporting them. #31606

Merged
merged 1 commit into from
Mar 8, 2016

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Feb 12, 2016

No description provided.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@oli-obk
Copy link
Contributor

oli-obk commented Feb 12, 2016

the commit message needs a [breaking-change]

@nikomatsakis
Copy link
Contributor

I'm not convinced this sort of change out to be tagged with [breaking-change]. It's one thing to tag changes to libsyntax which (unfortunately, in my view) has a kind of "semi-stable" status, but the internals of rustc don't fall in that category.

@oli-obk
Copy link
Contributor

oli-obk commented Feb 12, 2016

it's reachable from late lints, I just assumed that any change observable from plugins would require the mark so we can find the commits easily

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 15, 2016

I can see the argument for including it, but I haven't done that with similar changes I made earlier. Happy to go either way.

@alexcrichton
Copy link
Member

r? @eddyb (or anyone else from the compilers team)

@alexcrichton alexcrichton assigned eddyb and unassigned brson Mar 8, 2016
@eddyb
Copy link
Member

eddyb commented Mar 8, 2016

Pretty! @bors r+

@bors
Copy link
Contributor

bors commented Mar 8, 2016

📌 Commit c6474af has been approved by eddyb

@bors
Copy link
Contributor

bors commented Mar 8, 2016

⌛ Testing commit c6474af with merge a9ffe67...

bors added a commit that referenced this pull request Mar 8, 2016
Rename ClosureKind variants and stop re-exporting them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants