Update jemalloc again #31889
Merged
Update jemalloc again #31889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
We may want to consider holding this off until after the release? It's super easy to backport a downgrade, however, so it may not be that critical. |
|
☔ The latest upstream changes (presumably #31846) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
update-jemalloc-again
branch
from
6ae7423
to
93191cc
Compare
|
Just a note that 4.1.0 has just been released, so it might be worth going for that? |
alexcrichton
force-pushed
the
update-jemalloc-again
branch
from
93191cc
to
c5fdd8d
Compare
|
Good point! I've rebased the jemalloc branch again |
|
r=me -- but I think at this point we might as well wait until the release |
bors
added a commit
that referenced
this pull request
Mar 3, 2016
…akis Now that jemalloc/jemalloc@767d850 is upstream, the relevant deadlocking issue which prompted our downgrade has been resolved. As a result, there's no known issue to *not* upgrade! This also re-enables jemalloc for the pc-windows-gnu target as known issues with that have also been fixed. Closes #31030
|
💔 Test failed - auto-linux-64-x-android-t |
alexcrichton
force-pushed
the
update-jemalloc-again
branch
from
c5fdd8d
to
3069534
Compare
|
@bors: r=nikomatsakis 3069534fa76aa9f11c30e8483cccc467c3e880d4 |
|
⌛ Testing commit 3069534 with merge 97b2474... |
|
💔 Test failed - auto-linux-musl-64-opt |
Right now there's just a smattering of `// ignore-foo` platforms which is ever expanding as new ones are added. Instead switch to only running these tests on Linux/OSX and then use a guaranteed-to-work but not-as-well-tested alternative on other platforms.
alexcrichton
force-pushed
the
update-jemalloc-again
branch
from
3069534
to
df9e173
Compare
bors
added a commit
that referenced
this pull request
Mar 5, 2016
…akis Now that jemalloc/jemalloc@767d850 is upstream, the relevant deadlocking issue which prompted our downgrade has been resolved. As a result, there's no known issue to *not* upgrade! This also re-enables jemalloc for the pc-windows-gnu target as known issues with that have also been fixed. Closes #31030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that jemalloc/jemalloc@767d850 is upstream, the relevant deadlocking issue which prompted our downgrade has been resolved. As a result, there's no known issue to not upgrade! This also re-enables jemalloc for the pc-windows-gnu target as known issues with that have also been fixed.
Closes #31030