Rollup of 7 pull requests #31932
Merged
Rollup of 7 pull requests #31932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Feb 27, 2016
Manishearth
commented
- Successful merges: documentation fix #31909, Add f32 and f64 examples warning #31918, Fix typo in release notes #31922, more check_*_post methods for LintPasses #31926, std: Stabilize APIs for the 1.8 release #31928, Avoid excessive reallocations during item-bodies checking #31929, Improvements to the primitive str documentation #31930
- Failed merges:
`continue` expression's description mentioned `break` instead of `continue` Signed-off-by: benaryorg <binary@benary.org>
When foldings Substs, we map over VecPerParamSpace instances using EnumeratedItems which does not provide an accurate size_hint() in its Iterator implementation. This leads to quite a large number or reallocations. Providing a suitable size_hint() implementation reduces the time spent in item-bodies checking quite a bit. ``` crate | before | after | ~change -------|------------------------- core | 7.28s | 5.44s | -25% std | 2.07s | 1.88s | -9.2% syntax | 8.86s | 8.30s | -6.3% ```
Adds extra documentation links for library types and methods to be consistent with similar items already linked. Also includes minor formatting fixes.
|
@bors r+ p=20 |
|
📌 Commit 9c63c56 has been approved by |
|
⌛ Testing commit 9c63c56 with merge ef48928... |
|
💔 Test failed - auto-win-gnu-32-nopt-t |
`continue` expression's description mentioned `break` instead of `continue`
These `_post` methods are quite helpful to control lint behavior without storing e.g. block node ids. So here are a few more I believe will be helpful. r? @Manishearth
When foldings Substs, we map over VecPerParamSpace instances using EnumeratedItems which does not provide an accurate size_hint() in its Iterator implementation. This leads to quite a large number or reallocations. Providing a suitable size_hint() implementation reduces the time spent in item-bodies checking quite a bit. ``` crate | before | after | ~change -------|------------------------- core | 7.28s | 5.44s | -25% std | 2.07s | 1.88s | -9.2% syntax | 8.86s | 8.30s | -6.3% ```
Hello. I've added links for items inside of some stable methods for consistency with existing ones that already have them. Also includes minor formatting fixes. r? @steveklabnik
|
@bors r+ p=10 force |
|
📌 Commit 7f59c21 has been approved by |
|
⌛ Testing commit 7f59c21 with merge 8082137... |
|
💔 Test failed - auto-win-gnu-32-opt |
|
@bors retry force |
bors
added a commit
that referenced
this pull request
Feb 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.