Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Fix tracking issues and clean deprecated APIs #32112

Merged
merged 7 commits into from
Mar 13, 2016
Merged

std: Fix tracking issues and clean deprecated APIs #32112

merged 7 commits into from
Mar 13, 2016

Conversation

alexcrichton
Copy link
Member

This PR fixes up a number of discrepancies found with tracking issues (some closed, some needed new ones, etc), and also cleans out all pre-1.8 deprecated APIs. The big beast here was dealing with std::dynamic_lib, and via many applications of a large hammer it's now out of the standard library.

@alexcrichton
Copy link
Member Author

r? @aturon

@alexcrichton alexcrichton force-pushed the fix-issues branch 2 times, most recently from 138fbf4 to d481d39 Compare March 8, 2016 23:57
@bors
Copy link
Contributor

bors commented Mar 11, 2016

☔ The latest upstream changes (presumably #32133) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the fix-issues branch 2 times, most recently from c802813 to d80fb96 Compare March 11, 2016 23:54
@aturon
Copy link
Member

aturon commented Mar 11, 2016

r=me, very nice.

@alexcrichton
Copy link
Member Author

@bors: r=aturon 2c54926a1cc661e42b00c1cebe7a4ccb643cbf65

@bors
Copy link
Contributor

bors commented Mar 12, 2016

☔ The latest upstream changes (presumably #32200) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
alloc: Add unstable issue for FnBox APIs
3dd8b3e
@alexcrichton
test: Move some test outputs into $(TMPDIR)
9a623f3 
Don't want to pollute the source tree!
@alexcrichton
std: Remove unstable from ReentrantMutex
1c440bd 
This isn't exported so it doesn't need a tag.
@alexcrichton
core: Mark Wrapping impls as stable
a38bf6e 
These are all insta-stable anyway, so just properly tag them.
@alexcrichton
core: Make a new tracking issue for prelude traits
aed7dda 
The referenced issues here were both closed, so hook up a new issue which tracks
specifically the prelude traits being unstable.
@alexcrichton
std: Add a tracking issue for Peekable::is_empty
083db64 
The listed tracking issue was hooked up to the wrong location by accident.
@alexcrichton
Copy link
Member Author

@bors: r=aturon 95812ac

@Manishearth Manishearth mentioned this pull request Mar 12, 2016
Closed
@sfackler
Copy link
Member

Travis is unhappy: https://travis-ci.org/rust-lang/rust/builds/115483851#L1725

@bors
Copy link
Contributor

bors commented Mar 12, 2016

⌛ Testing commit 95812ac with merge 08d32fa...

@Manishearth
Copy link
Member 

../src/libstd\sys/unix\net.rs:24:1: 24:31 warning: `pub extern crate` does not work as expected and should not be used. Likely to become an error. Prefer `extern crate` and `pub use`.
../src/libstd\sys/unix\net.rs:24 pub extern crate libc as netc;
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/libstd\sys/windows\handle.rs:138:48: 138:56 error: unresolved name `c::FALSE` [E0425]
../src/libstd\sys/windows\handle.rs:138             let wait = if wait {c::TRUE} else {c::FALSE};
                                                                                       ^~~~~~~~
../src/libstd\sys/windows\handle.rs:138:48: 138:56 help: run `rustc --explain E0425` to see a detailed explanation
../src/libstd\sys/windows\pipe.rs:143:57: 143:65 error: unresolved name `c::FALSE` [E0425]
../src/libstd\sys/windows\pipe.rs:143             c::WaitForMultipleObjects(2, objs.as_ptr(), c::FALSE, c::INFINITE)
                                                                                              ^~~~~~~~
../src/libstd\sys/windows\pipe.rs:143:57: 143:65 help: run `rustc --explain E0425` to see a detailed explanation

@bors
Copy link
Contributor

bors commented Mar 12, 2016

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Contributor

bors commented Mar 12, 2016

⌛ Testing commit 95812ac with merge 51644a9...

@bors
Copy link
Contributor

bors commented Mar 12, 2016

💔 Test failed - auto-win-msvc-32-opt

@alexcrichton
Copy link
Member Author

@bors: r=aturon c2c5092

@bors
Copy link
Contributor

bors commented Mar 12, 2016

⌛ Testing commit c2c5092 with merge b5241a8...

@bors
Copy link
Contributor

bors commented Mar 12, 2016

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton
std: Clean out deprecated APIs
b53764c 
Removes all unstable and deprecated APIs prior to the 1.8 release. All APIs that
are deprecated in the 1.8 release are sticking around for the rest of this
cycle.

Some notable changes are:

* The `dynamic_lib` module was moved into `rustc_back` as the compiler still
  relies on a few bits and pieces.
* The `DebugTuple` formatter now special-cases an empty struct name with only
  one field to append a trailing comma.
@alexcrichton
Copy link
Member Author

@bors: r=aturon b53764c

@bors
Copy link
Contributor

bors commented Mar 12, 2016

⌛ Testing commit b53764c with merge a2c56de...

bors added a commit that referenced this pull request Mar 12, 2016
@bors
Auto merge of #32112 - alexcrichton:fix-issues, r=aturon
a2c56de 
std: Fix tracking issues and clean deprecated APIs

This PR fixes up a number of discrepancies found with tracking issues (some closed, some needed new ones, etc), and also cleans out all pre-1.8 deprecated APIs. The big beast here was dealing with `std::dynamic_lib`, and via many applications of a large hammer it's now out of the standard library.
@bors
Copy link
Contributor

bors commented Mar 13, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit b53764c into rust-lang:master Mar 13, 2016
This was referenced Mar 13, 2016
Closed
Merged
Closed
Closed
@jfager jfager mentioned this pull request Mar 25, 2016
Closed
@alexcrichton alexcrichton deleted the fix-issues branch March 27, 2016 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @bors @aturon @sfackler @Manishearth