Do not report errors from regionck if other errors were already reported #32164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reported during the lifetime of this inferencer. Fixes rust-lang#30580.
|
cc @eddyb |
|
@bors r+ |
|
📌 Commit 0ddc17d has been approved by |
nikomatsakis
added
the
beta-nominated
|
Nominating for beta. Tiny diff, but these errors seem to have become much more common lately. |
nikomatsakis
added
T-compiler
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 12, 2016
Do not report errors from regionck if other errors were already reported Do not report errors from regionck if other errors were already reported during the lifetime of this inferencer. Fixes rust-lang#30580. r? @arielb1
|
⌛ Testing commit 0ddc17d with merge 4bedc11... |
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors retry |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 13, 2016
Do not report errors from regionck if other errors were already reported Do not report errors from regionck if other errors were already reported during the lifetime of this inferencer. Fixes rust-lang#30580. r? @arielb1
|
@rust-lang/tools We need a snapshot after this to make compiler development bearable, but at the same time, we'll want a snapshot after #32080 to set up the test bot, not sure how long review will take. |
|
I'll plan on making a new snapshot once #32080 lands and if that takes too long can just go ahead and do it sooner. |
bors
added a commit
that referenced
this pull request
Mar 20, 2016
Update snapshots to 2016-03-18 (235d774). The new snapshots notably include @nikomatsakis' #32164 fix for the regionck error spew. Also, `./configure --enable-orbit` *and/or* `make RUSTFLAGS="-Z orbit"` should work now (#32080).
brson
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not report errors from regionck if other errors were already reported during the lifetime of this inferencer. Fixes #30580.
r? @arielb1