mk: Add configure option for disabling codegen tests #32168
Conversation
|
cc @wycats @LeoUnglaub |
|
r? @brson |
|
Also note that this is only "lightly tested" currently |
|
I looked over the code and for me it looks good. But even with that patch i was unable of building it myself. But that is something for another ticket. This one looks good for me. Bit thanks for taking on this issue! You are the best! |
|
☔ The latest upstream changes (presumably #32080) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
fix-filecheck
branch
from
c0954a7
to
295a70f
Compare
|
@bors: r+ |
|
📌 Commit 295a70f has been approved by |
|
⌛ Testing commit 295a70f with merge 660fa89... |
|
💔 Test failed - auto-win-msvc-64-opt-rustbuild |
|
@bors: retry On Fri, Apr 1, 2016 at 8:38 PM, bors notifications@github.com wrote:
|
|
⌛ Testing commit 295a70f with merge 0918f82... |
|
💔 Test failed - auto-linux-64-nopt-t |
Our `codegen` test suite requires the LLVM `FileCheck` utility but unfortunately this isn't always available in all custom LLVM roots (e.g. those specified via `--llvm-root`). This commit adds a `./configure` option called `--disable-codegen-tests` which will manually disable running these tests. In the case that this option is passed we can forgo the need for the `FileCheck` executable. Note that we still require `FileCheck` by default as we will attempt to run these tests. Closes rust-lang#28667
alexcrichton
force-pushed
the
fix-filecheck
branch
from
295a70f
to
a3fdde7
Compare
|
@bors: r=aturon a3fdde7 |
|
⌛ Testing commit a3fdde7 with merge 0894b06... |
mk: Add configure option for disabling codegen tests Our `codegen` test suite requires the LLVM `FileCheck` utility but unfortunately this isn't always available in all custom LLVM roots (e.g. those specified via `--llvm-root`). This commit adds a `./configure` option called `--disable-codegen-tests` which will manually disable running these tests. In the case that this option is passed we can forgo the need for the `FileCheck` executable. Note that we still require `FileCheck` by default as we will attempt to run these tests. Closes #28667
Our
codegentest suite requires the LLVMFileCheckutility but unfortunatelythis isn't always available in all custom LLVM roots (e.g. those specified via
--llvm-root). This commit adds a./configureoption called--disable-codegen-testswhich will manually disable running these tests. Inthe case that this option is passed we can forgo the need for the
FileCheckexecutable. Note that we still require
FileCheckby default as we will attemptto run these tests.
Closes #28667